[PR PATCH] gsettings-desktop-schemas: missing font dependency

[PR PATCH] gsettings-desktop-schemas: missing font dependency

[c0m4r]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

There is a new pull request by c0m4r against master on the void-packages repository

https://github.com/c0m4r/void-packages patch-1
https://github.com/void-linux/void-packages/pull/48382

gsettings-desktop-schemas: missing font dependency
org.gnome.desktop.interface monospace-font-name default is 'Source Code Pro 10', which is missing
adding this dependency will fix default configuration with dependent packages like tilix, terminator and probably others

#### Testing the changes
- I tested the changes in this PR: **YES**


A patch file from https://github.com/void-linux/void-packages/pull/48382.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-48382.patch --]
[-- Type: text/x-diff, Size: 868 bytes --]

From 6da5779804d906f56fe697aba2b46fbb3dc3a04b Mon Sep 17 00:00:00 2001
From: c0m4r <github@wolfet.pl>
Date: Fri, 26 Jan 2024 17:26:05 +0100
Subject: [PATCH] gsettings-desktop-schemas: missing font dependency

---
 srcpkgs/gsettings-desktop-schemas/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/gsettings-desktop-schemas/template b/srcpkgs/gsettings-desktop-schemas/template
index 9028a5a30f45a..7217ab58b22d3 100644
--- a/srcpkgs/gsettings-desktop-schemas/template
+++ b/srcpkgs/gsettings-desktop-schemas/template
@@ -7,6 +7,7 @@ build_style=meson
 configure_args="-Dintrospection=$(vopt_if gir true false)"
 hostmakedepends="gettext pkg-config glib-devel"
 makedepends="libglib-devel"
+depends="font-adobe-source-code-pro"
 short_desc="Collection of GSettings schemas"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="LGPL-2.1-or-later"

Re: gsettings-desktop-schemas: missing font dependency

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/48382#issuecomment-1919424702

Comment:
The schema also references Cantarell, but GTK applications with client-side decorations still seem to function with an alternative font.

It would seem better to have the default schema reference generic font aliases rather than specific fonts.

Re: gsettings-desktop-schemas: missing font dependency

[c0m4r]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

New comment by c0m4r on void-packages repository

https://github.com/void-linux/void-packages/pull/48382#issuecomment-1919545113

Comment:
> The schema also references Cantarell, but GTK applications with client-side decorations still seem to function with an alternative font.

That's correct, however that's not the case in terminal emulators. You either need to provide the correct font or change the configuration pointing to the generic Monospace font (Debian does that). The idea is so it just works by default, without such changes.

> It would seem better to have the default schema reference generic font aliases rather than specific fonts.

It depends. I compared solutions used by other distros and I found this font as a dep less invasive and problematic. It's widely used and you don't need to modify schemas, nor configuration. By changing the default schemas there's no guarantee that it's not already overwritten by the local or user configuration, still pointing to the missing font. Moreover, this way we use native, consistent fonts. So in terms of user experience I'd vote for adding missing font the way that [Arch](https://archlinux.org/packages/extra/any/gsettings-desktop-schemas/) does that, rather that the overwriting schemas.

Re: gsettings-desktop-schemas: missing font dependency

[c0m4r]

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

New comment by c0m4r on void-packages repository

https://github.com/void-linux/void-packages/pull/48382#issuecomment-1919545113

Comment:
> The schema also references Cantarell, but GTK applications with client-side decorations still seem to function with an alternative font.

That's correct, however that's not the case in terminal emulators. You either need to provide the correct font or change the configuration pointing to the generic Monospace font (Debian does that). The idea is so it just works by default, without such changes.

> It would seem better to have the default schema reference generic font aliases rather than specific fonts.

It depends. I compared solutions used by other distros and I found this font as a dep less invasive and problematic. It's widely used and you don't need to modify schemas, nor configuration. By changing the default schemas there's no guarantee that it's not already overwritten by the local or user configuration, still pointing to the missing font. Moreover, this way we use native, consistent fonts. So in terms of user experience I'd vote for adding missing font the way that [Arch](https://archlinux.org/packages/extra/any/gsettings-desktop-schemas/) does that, rather that the overwriting schemas.

And even Debian's gsettings-desktop-schemas.gsettings-override mentions:

```
# Adobe Source Code Pro is not in Debian yet
# See https://bugs.debian.org/736681 and https://bugs.debian.org/762252
[org.gnome.desktop.interface]
monospace-font-name = 'Monospace 11'
```

so if we have the font in the repo, I think it's worth using it

Re: gsettings-desktop-schemas: missing font dependency

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 521 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/48382#issuecomment-1919672433

Comment:
My argument is that upstream should use a generic label, not necessarily that we should patch the schema. The reference to Cantarell may be considered a special case because the font is maintained by the GNOME project as the official UI font, whereas Source Code Pro is an external font whose associated use in terminal emulators is likely to incite a lot of passionate opinion.

Re: gsettings-desktop-schemas: missing font dependency

[c0m4r]

[-- Attachment #1: Type: text/plain, Size: 765 bytes --]

New comment by c0m4r on void-packages repository

https://github.com/void-linux/void-packages/pull/48382#issuecomment-1919805915

Comment:
> My argument is that upstream should use a generic label, not necessarily that we should patch the schema.

Agreed. Yet, I don't believe we're gonna influence such change.

> whereas Source Code Pro is an external font whose associated use in terminal emulators is likely to incite a lot of passionate opinion.

We'd better not get into THESE discussions ;) Though it's only a font, not the init system :)
But if it were to turn into such a big deal, the compromise solution is to make a schema patch or an override.
Just let me know, if there's no go for a font dep I'm gonna try to prepare an alternative solution.

Re: [PR PATCH] [Closed]: gsettings-desktop-schemas: missing font dependency

[c0m4r]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

There's a closed pull request on the void-packages repository

gsettings-desktop-schemas: missing font dependency
https://github.com/void-linux/void-packages/pull/48382

Description:
org.gnome.desktop.interface monospace-font-name default is 'Source Code Pro 10', which is missing
adding this dependency will fix default configuration with dependent packages like tilix, terminator and probably others

#### Testing the changes
- I tested the changes in this PR: **YES**