Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] strace: revbump
@ 2024-03-02 20:25 meator
  2024-03-02 20:55 ` icp1994
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: meator @ 2024-03-02 20:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]

There is a new pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages strace
https://github.com/void-linux/void-packages/pull/49037

strace: revbump
This fixes the

```
strace: Symbol `_UPT_accessors' has different size in shared object, consider re-linking
```

warning. I don't know what causes this warning. A proper solution that would prevent this warning from appearing again in the future would probably be better.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/49037.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-strace-49037.patch --]
[-- Type: text/x-diff, Size: 785 bytes --]

From 86a1f534e5ac7411b536a538e84248ffeceb430e Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Sat, 2 Mar 2024 21:22:22 +0100
Subject: [PATCH] strace: revbump

This fixes the

strace: Symbol `_UPT_accessors' has different size in shared object,
consider re-linking

warning.
---
 srcpkgs/strace/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/strace/template b/srcpkgs/strace/template
index 6448685e7967d8..483c3680db54f9 100644
--- a/srcpkgs/strace/template
+++ b/srcpkgs/strace/template
@@ -1,7 +1,7 @@
 # Template file for 'strace'
 pkgname=strace
 version=6.7
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--enable-silent-rules $(vopt_with libunwind)"
 makedepends="$(vopt_if libunwind libunwind-devel)"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: strace: revbump
  2024-03-02 20:25 [PR PATCH] strace: revbump meator
@ 2024-03-02 20:55 ` icp1994
  2024-03-02 21:34 ` oreo639
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: icp1994 @ 2024-03-02 20:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/49037#issuecomment-1974906810

Comment:
That's `libunwind`

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: strace: revbump
  2024-03-02 20:25 [PR PATCH] strace: revbump meator
  2024-03-02 20:55 ` icp1994
@ 2024-03-02 21:34 ` oreo639
  2024-03-02 21:47 ` [PR PATCH] [Updated] " meator
  2024-03-03  1:03 ` [PR PATCH] [Merged]: strace: rebuild against newer libunwind oreo639
  3 siblings, 0 replies; 5+ messages in thread
From: oreo639 @ 2024-03-02 21:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/49037#issuecomment-1974915176

Comment:
The message is coming from glibc: https://github.com/bminor/glibc/blob/d370155b9ab73d0c45bf968b7a9c823f4697a505/sysdeps/x86_64/dl-machine.h#L460

`_UPD_accessors` is a variable defined by libunwind that gets externed and the struct size was changed here: https://github.com/libunwind/libunwind/commit/d7e59261feb4f9425728ae08031bee3d5bf6e48a

The only use of `_UPD_accessors` in strace is passing its pointer back in to libunwind so afaict it shouldn't cause any noticeable issues in this instance: https://github.com/strace/strace/blob/8c480270653da45370fe44871dfdf18647bb0951/src/unwind-libunwind.c#L24

That being said, it should still be rebuilt as this is an ABI break.

Update the commit message to include the reason for the revbump and include the libunwind commit in the commit description.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] strace: revbump
  2024-03-02 20:25 [PR PATCH] strace: revbump meator
  2024-03-02 20:55 ` icp1994
  2024-03-02 21:34 ` oreo639
@ 2024-03-02 21:47 ` meator
  2024-03-03  1:03 ` [PR PATCH] [Merged]: strace: rebuild against newer libunwind oreo639
  3 siblings, 0 replies; 5+ messages in thread
From: meator @ 2024-03-02 21:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1511 bytes --]

There is an updated pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages strace
https://github.com/void-linux/void-packages/pull/49037

strace: revbump
This fixes the

```
strace: Symbol `_UPT_accessors' has different size in shared object, consider re-linking
```

warning. I don't know what causes this warning. A proper solution that would prevent this warning from appearing again in the future would probably be better.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/49037.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-strace-49037.patch --]
[-- Type: text/x-diff, Size: 928 bytes --]

From cc8238508fa02a6a9ad12c1c150f4b2d8d490ca0 Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Sat, 2 Mar 2024 21:22:22 +0100
Subject: [PATCH] strace: rebuild against newer libunwind

This fixes the

strace: Symbol `_UPT_accessors' has different size in shared object,
consider re-linking

warning.

An ABI break was introduced in
https://github.com/libunwind/libunwind/commit/d7e59261feb4f9425728ae08031bee3d5bf6e48a
---
 srcpkgs/strace/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/strace/template b/srcpkgs/strace/template
index 6448685e7967d8..483c3680db54f9 100644
--- a/srcpkgs/strace/template
+++ b/srcpkgs/strace/template
@@ -1,7 +1,7 @@
 # Template file for 'strace'
 pkgname=strace
 version=6.7
-revision=1
+revision=2
 build_style=gnu-configure
 configure_args="--enable-silent-rules $(vopt_with libunwind)"
 makedepends="$(vopt_if libunwind libunwind-devel)"

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: strace: rebuild against newer libunwind
  2024-03-02 20:25 [PR PATCH] strace: revbump meator
                   ` (2 preceding siblings ...)
  2024-03-02 21:47 ` [PR PATCH] [Updated] " meator
@ 2024-03-03  1:03 ` oreo639
  3 siblings, 0 replies; 5+ messages in thread
From: oreo639 @ 2024-03-03  1:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

There's a merged pull request on the void-packages repository

strace: rebuild against newer libunwind
https://github.com/void-linux/void-packages/pull/49037

Description:
This fixes the

```
strace: Symbol `_UPT_accessors' has different size in shared object, consider re-linking
```

warning. I don't know what causes this warning. A proper solution that would prevent this warning from appearing again in the future would probably be better.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-03-03  1:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-02 20:25 [PR PATCH] strace: revbump meator
2024-03-02 20:55 ` icp1994
2024-03-02 21:34 ` oreo639
2024-03-02 21:47 ` [PR PATCH] [Updated] " meator
2024-03-03  1:03 ` [PR PATCH] [Merged]: strace: rebuild against newer libunwind oreo639

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).