Development discussion of WireGuard
 help / color / mirror / Atom feed
* Re: [Patch] [testing][wireguard] Remove unneeded version.h include pointed out by 'make versioncheck'
       [not found] <83474b0e-9e44-642f-10c9-2e0ff94b06ca@gmail.com>
@ 2023-02-16 17:05 ` Alexander Lobakin
  2023-02-16 17:35 ` Jason A. Donenfeld
  1 sibling, 0 replies; 2+ messages in thread
From: Alexander Lobakin @ 2023-02-16 17:05 UTC (permalink / raw)
  To: Jesper Juhl
  Cc: linux-kernel, linux-kselftest, netdev, wireguard,
	Jason A. Donenfeld, Shuah Khan, Jakub Kicinski

From: Jesper Juhl <jesperjuhl76@gmail.com>
Date: Thu, 16 Feb 2023 02:01:05 +0100 (CET)

>> From e2fa4955c676960d0809e4afe8273075c94451c9 Mon Sep 17 00:00:00 2001
> From: Jesper Juhl <jesperjuhl76@gmail.com>
> Date: Mon, 13 Feb 2023 02:58:36 +0100
> Subject: [PATCH 06/12] [testing][wireguard] Remove unneeded version.h
> include
>  pointed out by 'make versioncheck'

Your patch is broken, pls resend.
Also I've no idea about the subject/prefix, shouldn't it be like:

[PATCH net-next] wireguard: selftests: remove unneeded version.h

?

> 
> Signed-off-by: Jesper Juhl <jesperjuhl76@gmail.com>
> ---
>  tools/testing/selftests/wireguard/qemu/init.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/wireguard/qemu/init.c
> b/tools/testing/selftests/wireguard/qemu/init.c
> index 3e49924dd77e..20d8d3192f75 100644
> --- a/tools/testing/selftests/wireguard/qemu/init.c
> +++ b/tools/testing/selftests/wireguard/qemu/init.c
> @@ -24,7 +24,6 @@
>  #include <sys/sysmacros.h>
>  #include <sys/random.h>
>  #include <linux/random.h>
> -#include <linux/version.h>
> 
>  __attribute__((noreturn)) static void poweroff(void)
>  {

Thanks,
Olek

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Patch] [testing][wireguard] Remove unneeded version.h include pointed out by 'make versioncheck'
       [not found] <83474b0e-9e44-642f-10c9-2e0ff94b06ca@gmail.com>
  2023-02-16 17:05 ` [Patch] [testing][wireguard] Remove unneeded version.h include pointed out by 'make versioncheck' Alexander Lobakin
@ 2023-02-16 17:35 ` Jason A. Donenfeld
  1 sibling, 0 replies; 2+ messages in thread
From: Jason A. Donenfeld @ 2023-02-16 17:35 UTC (permalink / raw)
  To: Jesper Juhl
  Cc: linux-kernel, linux-kselftest, netdev, wireguard, Shuah Khan,
	Jakub Kicinski

No idea if this is something intended for me to apply or if it's an
automated email. Fix the formatting, resend, and then maybe I'll apply
it?

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-16 17:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <83474b0e-9e44-642f-10c9-2e0ff94b06ca@gmail.com>
2023-02-16 17:05 ` [Patch] [testing][wireguard] Remove unneeded version.h include pointed out by 'make versioncheck' Alexander Lobakin
2023-02-16 17:35 ` Jason A. Donenfeld

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).