zsh-workers
 help / color / mirror / code / Atom feed
From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: Unreadable directories aren't included in glob expansion
Date: Wed, 04 Mar 2020 19:21:47 +0000	[thread overview]
Message-ID: <01a34cbb-1113-47f4-ac99-539ec29a473f@www.fastmail.com> (raw)
In-Reply-To: <5CE2B692-18F9-49EF-9D3C-2A0739BEF53F@kba.biglobe.ne.jp>

Jun T wrote on Tue, 03 Mar 2020 01:57 +00:00:
> 
> > 2020/02/28 23:55, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > 
> > Daniel Shahaf wrote on Fri, 28 Feb 2020 14:26 +0000:
> > 
> > Actually, it turns out that the test in question has already been fixed
> > on the 5.9 branch.  (I completely forgot about that before, sorry.  I only
> > ran into it now because I was trying to merge 5.9 into master.)
> > 
> > The fix is in commit edc04bd94656a152e17f06188bcef172d62a3ad4.
> > 
> > Could you check if D02 passes on the 5.9 branch on Cygwin?  If it does,
> > I'll merge master into 5.9, resolve the conflict on D02 by removing the
> > skip and leaving the test exit code and flags as "0:" (= pass), and then
> > merge 5.9 into master.
> 
> So you are going to fix the C code so that unreadable/unsearchable directory
> does match with "*/".
> 

Yes.  If you have any reservations about that, don't hesitate to raise them.

> On Cygwin, all of d000 d111 d444 match with */ on either master or 5.9
> branch. So the test D02 passes on 5.9 (with flag '0:').

Thanks.  I'll merge when I have time, but I don't know when I'll have time.

Cheers,

Daniel

      reply	other threads:[~2020-03-04 19:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200109154313eucas1p13b2e5465f21d059ea08537012e140236@eucas1p1.samsung.com>
     [not found] ` <20200109154145.rqksfenozx6745rn@tarpaulin.shahaf.local2>
     [not found]   ` <1578585101.6028.13.camel__24021.2781982095$1578585228$gmane$org@samsung.com>
     [not found]     ` <20200109172222.uwgyjouab45zk2gf__13897.4118557357$1578604026$gmane$org@chaz.gmail.com>
     [not found]       ` <20200110072753.yh7qms4w2gb44zcf@chaz.gmail.com>
     [not found]         ` <20200110170932.yz5wvd4uzr2taq57@tarpaulin.shahaf.local2>
2020-02-26 15:51           ` Jun. T
2020-02-27 13:00             ` Daniel Shahaf
2020-02-28  6:37               ` Jun T
2020-02-28  6:51                 ` Bart Schaefer
2020-02-28  7:57                   ` Jun T
2020-02-28 14:26                 ` Daniel Shahaf
2020-02-28 14:55                   ` Daniel Shahaf
2020-03-03  1:57                     ` Jun T
2020-03-04 19:21                       ` Daniel Shahaf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01a34cbb-1113-47f4-ac99-539ec29a473f@www.fastmail.com \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).