From: dana <dana@dana.is>
To: Daniel Hahler <genml+zsh-workers@thequod.de>
Cc: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: RFC: [PATCH] Completion/Unix/Command/_git: replace a few "*::" with "*:"
Date: Mon, 25 Feb 2019 13:14:01 -0600 [thread overview]
Message-ID: <11F88813-0A73-459B-825D-B5805870ABB8@dana.is> (raw)
In-Reply-To: <f67e0fb5-3dbd-4848-1535-1293ec16773e@gmail.com>
On 25 Feb 2019, at 04:04, Daniel Hahler <genml+zsh-workers@thequod.de> wrote:
>As for _git_checkout, the following appears to work better:
>...
>- '*:: :->branch-or-tree-ish-or-file' && ret=0
>+ '1: :->first-arg' \
>+ '*: :->other-arg' && ret=0
I only played with it for a second, but yes, that seems better to me. It does
produce a 'not a git repository' message when you complete options, though,
which is slightly irritating. I guess you could re-add that -* prefix check
there, can't think of anything nicer right now
Your white space is broken, also. That file does have some tabs in it, but
mostly it's spaces
dana
prev parent reply other threads:[~2019-02-25 19:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 13:58 Daniel Hahler
2019-02-24 19:46 ` dana
2019-02-25 9:46 ` Daniel Hahler
2019-02-25 10:04 ` Daniel Hahler
2019-02-25 19:14 ` dana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11F88813-0A73-459B-825D-B5805870ABB8@dana.is \
--to=dana@dana.is \
--cc=genml+zsh-workers@thequod.de \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).