From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Misc patches for git completion and vcs_info
Date: Fri, 12 Sep 2014 16:50:46 -0700 [thread overview]
Message-ID: <140912165046.ZM23739@torch.brasslantern.com> (raw)
In-Reply-To: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com>
On Sep 12, 11:30pm, Marc Finet wrote:
}
} Below is a list of patches that i added in my current zsh (based on
} tonight's master). Please consider them for review as my zsh-level is
} currently very low (e.g. patch 2) and i might have broken other use-cases
} (patch 4 for instance makes me a little bit nervous as it seems to easy).
(I think you left out the list.)
I'll leave it to one of the people who more regularly messes with VCS_Info
to apply these, but here's my brief take on each of them:
[PATCH 1/9] vcs_info examples: fix typo
- no issues with this one
[PATCH 2/9] completion git: support aliases when \n exist
- looks OK, but my "git config" foo is too weak to assess
PATCH 3/9] vcs_info git: detect revert or cherry-pick with multiple commits
- no issues
[PATCH 4/9] vcs_info git: set rrn before using it
- seems pretty obvious
[PATCH 5/9] vcs_info quilt: fix standalone detection
- I'm not sure this is correct; do we need to differentiate (( $# == 1 ))
from [[ -z "$2" ]] ?
[PATCH 6/9] vcs_info quilt: fix unapplied detection on sub-directory
- $(basename $patches) can be replaced with ${patches:t}
[PATCH 7/9] vcs_info git: fix applied-string name
- seems pretty obvious
[PATCH 8/9] vcs_info git: consider patches for rebase
- needs git foo currently beyond me to confirm correctness
[PATCH 9/9] completion git: fix send-email --confirm values
- no issues
next prev parent reply other threads:[~2014-09-12 23:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 21:30 Marc Finet
2014-09-12 21:30 ` [PATCH 1/9] vcs_info examples: fix typo Marc Finet
2014-09-14 9:33 ` Frank Terbeck
2014-09-12 21:30 ` [PATCH 2/9] completion git: support aliases when \n exist Marc Finet
2014-09-12 21:30 ` [PATCH 3/9] vcs_info git: detect revert or cherry-pick with multiple commits Marc Finet
2014-09-14 9:36 ` Frank Terbeck
2014-09-15 6:22 ` Phil Pennock
2014-09-12 21:30 ` [PATCH 4/9] vcs_info git: set rrn before using it Marc Finet
2014-09-14 9:33 ` Frank Terbeck
2014-09-16 20:07 ` Marc Finet
2014-09-16 20:41 ` Frank Terbeck
2014-09-16 20:57 ` Marc Finet
2014-09-16 21:23 ` Frank Terbeck
2014-09-12 21:30 ` [PATCH 5/9] vcs_info quilt: fix standalone detection Marc Finet
2014-09-14 9:42 ` Frank Terbeck
2014-09-16 20:19 ` Marc Finet
2014-09-12 21:30 ` [PATCH 6/9] vcs_info quilt: fix unapplied detection on sub-directory Marc Finet
2014-09-14 9:47 ` Frank Terbeck
2014-09-16 20:25 ` Marc Finet
2014-10-08 22:36 ` Marc Finet
2014-10-09 16:03 ` Frank Terbeck
2014-10-16 4:59 ` Marc Finet
2014-10-16 8:17 ` Frank Terbeck
2014-11-08 10:46 ` Marc Finet
2014-11-11 10:07 ` Marc Finet
2015-01-02 11:03 ` Frank Terbeck
2014-09-12 21:30 ` [PATCH 7/9] vcs_info git: fix applied-string name Marc Finet
2014-09-14 9:49 ` Frank Terbeck
2014-09-12 21:30 ` [PATCH 8/9] vcs_info git: consider patches for rebase Marc Finet
2014-09-14 10:08 ` Frank Terbeck
2014-09-14 10:13 ` Frank Terbeck
2014-09-16 20:07 ` Marc Finet
2014-09-12 21:30 ` [PATCH 9/9] completion git: fix send-email --confirm values Marc Finet
2014-09-14 10:11 ` Frank Terbeck
2014-09-12 23:50 ` Bart Schaefer [this message]
2014-09-13 7:35 ` Misc patches for git completion and vcs_info Marc Finet
2014-09-13 12:23 ` Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=140912165046.ZM23739@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).