From: Frank Terbeck <ft@bewatermyfriend.org>
To: Marc Finet <m.dreadlock@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 6/9] vcs_info quilt: fix unapplied detection on sub-directory
Date: Fri, 02 Jan 2015 12:03:24 +0100 [thread overview]
Message-ID: <871tndigw3.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <20141111100752.GA8974@mlap.lactee> (Marc Finet's message of "Tue, 11 Nov 2014 11:07:52 +0100")
Marc Finet wrote:
> Sorry for lack of reactivity ;|.
Sorry about that. I've been a fair bit busy the last months, getting my
masters thesis out the door and starting a new job. I'm slowly trying to
catch up with my backlog now.
> On Thu, Oct 16, 2014 at 10:17:56AM +0200, Frank Terbeck wrote:
>> Marc Finet wrote:
[...]
>> > So applied and unapplied lists are considered differents. The
>> > .pc/applied-patches file contains only relative paths.
>>
>> I see. That could be fixed, I guess. Either by making the unapplied list
>> absolute, or by trimming off the "repository's" root-directory from the
>> absolute paths before comparing.
> I do not see the point of specifying an absolute path for
> QUILT_PATCHES (or quilt-patch-dir) since relative path work with quilt
> (it automatically looks for upper directories if needed). Worse,
> specifying absolute path in QUILT_PATCHES makes quilt unable to create
> the .pc in the root since there is no root to deduce; on relative path,
> root is the path where the QUILT_PATCHES path is found. Anyway, the
> following patch fixes all the cases, i.e. specifying path (both absolute
> or "relative") in QUILT_PATCHES or quilt-patch-dir.
My idea about absolute directory names with $QUILT_PATCHES was to keep
the patch directories in a separate place that was unrelated to the
location of the source code.
I guess you're running with this patch enabled now, right? If this
current version works for you, I'd like to push it to the central
repository now.
Regards, Frank
next prev parent reply other threads:[~2015-01-02 11:22 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 21:30 Misc patches for git completion and vcs_info Marc Finet
2014-09-12 21:30 ` [PATCH 1/9] vcs_info examples: fix typo Marc Finet
2014-09-14 9:33 ` Frank Terbeck
2014-09-12 21:30 ` [PATCH 2/9] completion git: support aliases when \n exist Marc Finet
2014-09-12 21:30 ` [PATCH 3/9] vcs_info git: detect revert or cherry-pick with multiple commits Marc Finet
2014-09-14 9:36 ` Frank Terbeck
2014-09-15 6:22 ` Phil Pennock
2014-09-12 21:30 ` [PATCH 4/9] vcs_info git: set rrn before using it Marc Finet
2014-09-14 9:33 ` Frank Terbeck
2014-09-16 20:07 ` Marc Finet
2014-09-16 20:41 ` Frank Terbeck
2014-09-16 20:57 ` Marc Finet
2014-09-16 21:23 ` Frank Terbeck
2014-09-12 21:30 ` [PATCH 5/9] vcs_info quilt: fix standalone detection Marc Finet
2014-09-14 9:42 ` Frank Terbeck
2014-09-16 20:19 ` Marc Finet
2014-09-12 21:30 ` [PATCH 6/9] vcs_info quilt: fix unapplied detection on sub-directory Marc Finet
2014-09-14 9:47 ` Frank Terbeck
2014-09-16 20:25 ` Marc Finet
2014-10-08 22:36 ` Marc Finet
2014-10-09 16:03 ` Frank Terbeck
2014-10-16 4:59 ` Marc Finet
2014-10-16 8:17 ` Frank Terbeck
2014-11-08 10:46 ` Marc Finet
2014-11-11 10:07 ` Marc Finet
2015-01-02 11:03 ` Frank Terbeck [this message]
2014-09-12 21:30 ` [PATCH 7/9] vcs_info git: fix applied-string name Marc Finet
2014-09-14 9:49 ` Frank Terbeck
2014-09-12 21:30 ` [PATCH 8/9] vcs_info git: consider patches for rebase Marc Finet
2014-09-14 10:08 ` Frank Terbeck
2014-09-14 10:13 ` Frank Terbeck
2014-09-16 20:07 ` Marc Finet
2014-09-12 21:30 ` [PATCH 9/9] completion git: fix send-email --confirm values Marc Finet
2014-09-14 10:11 ` Frank Terbeck
2014-09-12 23:50 ` Misc patches for git completion and vcs_info Bart Schaefer
2014-09-13 7:35 ` Marc Finet
2014-09-13 12:23 ` Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tndigw3.fsf@ft.bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=m.dreadlock@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).