zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: Add redis-db module to upstream?
Date: Wed, 07 Jun 2017 13:04:46 +0000	[thread overview]
Message-ID: <1496840686.3630909.1001656432.1D029467@webmail.messagingengine.com> (raw)
In-Reply-To: <16324.1496827747@thecus.kiddle.eu>

Oliver Kiddle wrote on Wed, 07 Jun 2017 11:29 +0200:
> On 3 Jun, Daniel Shahaf wrote:
> > > I have no objection to including this module's functionality in the base
> > > distribution.  However, I don't think we should just chuck it in there
> > > exactly as-is.
> >
> > This module was created 10 days ago.  It has had no bug reports, no pull
> > requests, and no code contributors other than its author.  Does it have
> > any users besides Sebastian?  Will anyone on this list use this module
> > in his setup?
> 
> I'm not sure that those points are entirely fair because building zsh modules
> separate from the zsh tree is not trivial. It's a significant barrier
> both to any potential contributor trying the module and to long term
> usage as a separate module. If it was easy then it might be better to
> keep such modules separate but it isn't.

Then let's make it easier for people to develop and install separately-
maintained modules.

As to keeping such modules separate, this _is_ git, so module developers
could maintain their modules in forks of zsh.git, and users could
install modules by merging all modules they want to use into their tree
before running Util/preconfig.  I don't consider this a solution; only a
workaround until the core's build system is improved to make it easier
to use externally-maintained modules.

The build system improvement is independent of whether the redis module
should be in the core.

Cheers,

Daniel


  parent reply	other threads:[~2017-06-07 13:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-03  3:24 Sebastian Gniazdowski
2017-06-03 17:09 ` Bart Schaefer
2017-06-03 19:35   ` Daniel Shahaf
2017-06-04  5:57     ` Sebastian Gniazdowski
2017-06-04  6:23       ` Sebastian Gniazdowski
2017-06-06  2:28     ` Eric Cook
2017-06-07  9:29     ` Oliver Kiddle
2017-06-07 11:08       ` Sebastian Gniazdowski
2017-06-07 13:04       ` Daniel Shahaf [this message]
2017-06-07 22:10       ` Bart Schaefer
2017-06-04  8:35   ` Sebastian Gniazdowski
2017-06-08  4:01 Sebastian Gniazdowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1496840686.3630909.1001656432.1D029467@webmail.messagingengine.com \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).