From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Add redis-db module to upstream?
Date: Sat, 3 Jun 2017 10:09:08 -0700 [thread overview]
Message-ID: <170603100908.ZM13230@torch.brasslantern.com> (raw)
In-Reply-To: <etPan.59322bde.6763845e.1a9@MacMini.local>
I have no objection to including this module's functionality in the base
distribution. However, I don't think we should just chuck it in there
exactly as-is.
Primarily, we should first decide where this should live in the module
hierarchy, i.e., what name should it have?
For example would it be appropriate to put it under zsh/db/redis and
finally do the work of abstracting ztie out of db_gdbm? (I know this
supports some operations that the base ztie interface does not.)
In that vein, this also introduces a question of whether zsh/db/ needs
to generically support a password mechanism. I'd suggest that it use
a parameter, possibly a hash with PM_HIDEVAL set whose keys are chosen
from arguments of ztie, but that's just a first reaction and probably
needs more thought. Unlike the naming decision, this doesn't need to
be determined before the module is otherwise integrated.
There are probably a few other design questions of this sort that will
arise in due course.
next prev parent reply other threads:[~2017-06-03 17:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 3:24 Sebastian Gniazdowski
2017-06-03 17:09 ` Bart Schaefer [this message]
2017-06-03 19:35 ` Daniel Shahaf
2017-06-04 5:57 ` Sebastian Gniazdowski
2017-06-04 6:23 ` Sebastian Gniazdowski
2017-06-06 2:28 ` Eric Cook
2017-06-07 9:29 ` Oliver Kiddle
2017-06-07 11:08 ` Sebastian Gniazdowski
2017-06-07 13:04 ` Daniel Shahaf
2017-06-07 22:10 ` Bart Schaefer
2017-06-04 8:35 ` Sebastian Gniazdowski
2017-06-08 4:01 Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170603100908.ZM13230@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).