zsh-workers
 help / color / mirror / code / Atom feed
From: Sebastian Gniazdowski <psprint@zdharma.org>
To: zsh-workers@zsh.org
Subject: Add redis-db module to upstream?
Date: Sat, 3 Jun 2017 05:24:14 +0200	[thread overview]
Message-ID: <etPan.59322bde.6763845e.1a9@MacMini.local> (raw)

Hello
The module https://github.com/zdharma/zredis is interesting because:

- needs only hiredis package, which is a small modern-C-style library
    - for example it uses sds string library https://github.com/antirez/sds which has a header stored before pointers passed around, making them both C-strings and custom structures (with length stored)

- is well tested – complete coverage in test suite, also separate test suite for testing with Valgrind

- exercises all Zsh data types, so other module creators will have a nice example code

- has a use case – I imagine db administrator binding key "visitors" to Zsh scalar parameter $visitors, to do echo $visitors many times across the day

If we will agree on adding this module I will sent a patch including update of configure.ac. I would still distribute my module, because it can be loaded into Zsh without recompilation of Zsh, and to any Zsh version.

Distributing with Zsh would boost awareness of what Zsh can do. Someone could be inspired by this module if in upstream, while I see it being ignored if only as a plugin.

--
Sebastian Gniazdowski
psprint /at/ zdharma.org


             reply	other threads:[~2017-06-03  3:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-03  3:24 Sebastian Gniazdowski [this message]
2017-06-03 17:09 ` Bart Schaefer
2017-06-03 19:35   ` Daniel Shahaf
2017-06-04  5:57     ` Sebastian Gniazdowski
2017-06-04  6:23       ` Sebastian Gniazdowski
2017-06-06  2:28     ` Eric Cook
2017-06-07  9:29     ` Oliver Kiddle
2017-06-07 11:08       ` Sebastian Gniazdowski
2017-06-07 13:04       ` Daniel Shahaf
2017-06-07 22:10       ` Bart Schaefer
2017-06-04  8:35   ` Sebastian Gniazdowski
2017-06-08  4:01 Sebastian Gniazdowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=etPan.59322bde.6763845e.1a9@MacMini.local \
    --to=psprint@zdharma.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).