From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: Pasting UTF-8 characters with bracketed-paste-magic seems broken in 5.1
Date: Fri, 11 Sep 2015 12:22:59 -0700 [thread overview]
Message-ID: <150911122259.ZM8932@torch.brasslantern.com> (raw)
In-Reply-To: <20150911184129.46145c0e@ntlworld.com>
On Sep 11, 6:41pm, Peter Stephenson wrote:
}
} > Given this, if your patch from 36483 seems to work for you, go ahead and
} > commit it so you can do the 5.1.1 release.
}
} I simply tried it with a few simple accented latin characters and it
} seemed to work. It doesn't sound like it's had much testing otherwise.
} I've committed it.
Now that it's out:
(1) someone who was experiencing the multibyte problem should try it again
(2) it should be tested for the case where a multibyte character is bound
to a widget that has been declared in active-widgets
I'm actually pretty sure this is still broken for obscure cases, but in
fact the whole scheme in which multi-byte recognition is buried inside
the self-insert widget is probaby also broken for those same cases even
when simply typing. E.g., if I override the self-insert widget with my
own, my widget is only going to get passed in $KEYS the first byte of
any multibyte character. (Just verified this with 4.3.17.)
Compare:
shove-in-LBUFFER() { LBUFFER+=$KEYS }
zle -N self-insert shove-in-LBUFFER
Against:
call-self-insert() { zle .self-insert }
zle -N self-insert call-self-insert
With shove-in-LBUFFER, pasting a three-byte multibyte character results
in interpretation as three separate characters. With call-self-insert,
the trailing bytes are picked up by getrestchar() and the insert works.
So we're no worse off than before, but this needs re-thinking.
next prev parent reply other threads:[~2015-09-11 19:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 15:57 Axel Beckert
2015-09-10 11:17 ` Axel Beckert
2015-09-10 15:26 ` Yuri D'Elia
2015-09-10 14:39 ` Bart Schaefer
2015-09-10 14:57 ` Axel Beckert
2015-09-10 15:45 ` Bart Schaefer
2015-09-10 16:07 ` Peter Stephenson
2015-09-10 16:16 ` Bart Schaefer
2015-09-10 16:28 ` Peter Stephenson
2015-09-10 18:57 ` Peter Stephenson
2015-09-10 19:35 ` Peter Stephenson
2015-09-10 23:24 ` Bart Schaefer
2015-09-11 8:10 ` Peter Stephenson
2015-09-11 9:42 ` Axel Beckert
2015-09-11 15:33 ` Bart Schaefer
2015-09-11 17:41 ` Peter Stephenson
2015-09-11 19:22 ` Bart Schaefer [this message]
2015-09-11 19:49 ` Axel Beckert
2015-09-11 20:04 ` Axel Beckert
2015-09-11 21:53 ` Daniel Shahaf
2015-09-10 19:20 ` Bart Schaefer
2015-09-10 19:29 ` Bart Schaefer
2015-09-10 19:53 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=150911122259.ZM8932@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).