zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: Pasting UTF-8 characters with bracketed-paste-magic seems broken in 5.1
Date: Thu, 10 Sep 2015 17:07:05 +0100	[thread overview]
Message-ID: <20150910170705.0fbeb302@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <150910084516.ZM22892@torch.brasslantern.com>

On Thu, 10 Sep 2015 08:45:16 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Sep 10,  4:57pm, Axel Beckert wrote:
> }
> } > (1) There is a problem handling multibyte characters in the built-in
> } > read-commmand widget; or
> } > 
> } > (2) There is a problem with using ${PASTED#$KEYS} to remove multi-byte
> } > characters from the beginning of the pasted text.
> } 
> } (2) looks fine on a first glance:
> } 
> } PASTED=äoö
> } KEYS=äo
> } echo ${PASTED#$KEYS}
> } ö
> 
> Yes, but KEYS is a ZLE local so its content may be escaped or something.

read-command doesn't explicitly handle multibyte characters in the way
self-insert does.  self-insert gets the remainder of the character.
That doesn't work for you because you want KEYS to be correct before the
self-insert.  KEYS refers to the level where you originally read the
keys, in getkeybuf() / getkeymapcmd(), and at this point you've only got
the initial byte.

So I'm not sure what the fix is.  I think it might be (despite what the
comment in getkeymapcmd() currently says) to move the special stuff down
to the end of getkeymapcmd() and posprocess it into keybuf, which isn't
very nice but, well.  I'll look later on.

Can't really see a good reason for not producing a bug fix version anyway,
though, since there's plenty of stuff needs fixing.

pws


  reply	other threads:[~2015-09-10 16:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-06 15:57 Axel Beckert
2015-09-10 11:17 ` Axel Beckert
2015-09-10 15:26   ` Yuri D'Elia
2015-09-10 14:39 ` Bart Schaefer
2015-09-10 14:57   ` Axel Beckert
2015-09-10 15:45     ` Bart Schaefer
2015-09-10 16:07       ` Peter Stephenson [this message]
2015-09-10 16:16         ` Bart Schaefer
2015-09-10 16:28           ` Peter Stephenson
2015-09-10 18:57             ` Peter Stephenson
2015-09-10 19:35               ` Peter Stephenson
2015-09-10 23:24                 ` Bart Schaefer
2015-09-11  8:10                   ` Peter Stephenson
2015-09-11  9:42                     ` Axel Beckert
2015-09-11 15:33                     ` Bart Schaefer
2015-09-11 17:41                       ` Peter Stephenson
2015-09-11 19:22                         ` Bart Schaefer
2015-09-11 19:49                           ` Axel Beckert
2015-09-11 20:04                             ` Axel Beckert
2015-09-11 21:53               ` Daniel Shahaf
2015-09-10 19:20             ` Bart Schaefer
2015-09-10 19:29               ` Bart Schaefer
2015-09-10 19:53                 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150910170705.0fbeb302@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).