zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: Pasting UTF-8 characters with bracketed-paste-magic seems broken in 5.1
Date: Fri, 11 Sep 2015 09:10:31 +0100	[thread overview]
Message-ID: <20150911091031.0a227ebd@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <150910162415.ZM3990@torch.brasslantern.com>

On Thu, 10 Sep 2015 16:24:15 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Sep 10,  8:35pm, Peter Stephenson wrote:
> }
> } This seems to be getting somewhere, but possibly needs more expert
> } examination...
> 
> This diff looks OK, though I'm not sure why you need $ismb ?  Is it just
> a shortcut?  (i.e., because if the multibyte character had been bound to
> something, then .read-command would have consumed it as one $KEYS, so
> we know it can't match $bpm_inactive)

It didn't work otherwise.  I don't know what the pattern match was doing
that would cause it to go down the wrong way.

> Thinking harder, though ... isn't the only reason that this gets "stuck"
> because "zle .self-insert-unmeta" blocks waiting for more bytes?  Do we
> really need the loop-within-a-loop given LBUFFER+= instead?  Perhaps
> because the trailing part of the multibyte character might be bound to
> an active widget?

That's correct about self-insert, but if we don't have the loop, I'm not
sure we've done enough analysis to decide between executing a command
and putting stuff in the buffer.  But feel free to experiment as you
know the sort of things that should work.

I should say I don't really have any interest in this beyond getting it
basically working as a proof of concept --- if you want to tweak it
further, go ahead.  An elegant fix to the internals of the line editor
can wait.

pws


  reply	other threads:[~2015-09-11  8:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-06 15:57 Axel Beckert
2015-09-10 11:17 ` Axel Beckert
2015-09-10 15:26   ` Yuri D'Elia
2015-09-10 14:39 ` Bart Schaefer
2015-09-10 14:57   ` Axel Beckert
2015-09-10 15:45     ` Bart Schaefer
2015-09-10 16:07       ` Peter Stephenson
2015-09-10 16:16         ` Bart Schaefer
2015-09-10 16:28           ` Peter Stephenson
2015-09-10 18:57             ` Peter Stephenson
2015-09-10 19:35               ` Peter Stephenson
2015-09-10 23:24                 ` Bart Schaefer
2015-09-11  8:10                   ` Peter Stephenson [this message]
2015-09-11  9:42                     ` Axel Beckert
2015-09-11 15:33                     ` Bart Schaefer
2015-09-11 17:41                       ` Peter Stephenson
2015-09-11 19:22                         ` Bart Schaefer
2015-09-11 19:49                           ` Axel Beckert
2015-09-11 20:04                             ` Axel Beckert
2015-09-11 21:53               ` Daniel Shahaf
2015-09-10 19:20             ` Bart Schaefer
2015-09-10 19:29               ` Bart Schaefer
2015-09-10 19:53                 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150911091031.0a227ebd@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).