* [PATCH] Fix completion error about 'm' option of 'install' command
@ 2018-07-19 4:08 Yasuhiro KIMURA
2018-07-19 5:02 ` Daniel Shahaf
0 siblings, 1 reply; 5+ messages in thread
From: Yasuhiro KIMURA @ 2018-07-19 4:08 UTC (permalink / raw)
To: zsh-workers
Hello,
I found following error happens while completing 'm' option of
'install' command.
yasu@rolling-vm-freebsd1[2016]% install -m_arguments:463: command not found: _modes ~
And patch below fixes it.
diff --git a/Completion/Unix/Command/_install b/Completion/Unix/Command/_install
index f5056b5d0..4feb34ebf 100644
--- a/Completion/Unix/Command/_install
+++ b/Completion/Unix/Command/_install
@@ -11,7 +11,7 @@ common_args=(
'(-C -c --compare)-c[copy files (default)]'
'(-d --directory)'{-d,--directory}'[create directories]'
'(-g --group)'{-g+,--group=}'[specify destination file group]: :_groups'
- '(-m --mode)'{-m+,--mode=}'[specify destination file mode]: :_modes'
+ '(-m --mode)'{-m+,--mode=}'[specify destination file mode]: :_file_modes'
'(-o --owner)'{-o+,--owner=}'[specify destination file owner]: :_users'
'(-p --preserve-timestamps)'{-p,--preserve-timestamps}'[preserve modification times]'
'(-s --strip)'{-s,--strip}'[strip binaries]'
Best Regards.
PS. Please CC to me because I don't subscribe this ML.
---
Yasuhiro KIMURA
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix completion error about 'm' option of 'install' command
2018-07-19 4:08 [PATCH] Fix completion error about 'm' option of 'install' command Yasuhiro KIMURA
@ 2018-07-19 5:02 ` Daniel Shahaf
2018-07-19 5:43 ` Jun T
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Daniel Shahaf @ 2018-07-19 5:02 UTC (permalink / raw)
To: Yasuhiro KIMURA, zsh-workers
Yasuhiro KIMURA wrote on Thu, 19 Jul 2018 13:08 +0900:
> I found following error happens while completing 'm' option of
> 'install' command.
>
> yasu@rolling-vm-freebsd1[2016]% install -m_arguments:463: command not
> found: _modes ~
>
> And patch below fixes it.
>
Thank you for the patch; applied and pushed.
This is a regression from 42214, released in 5.5. Sounds like we might
need a README/NEWS entry for this, as an incompatible change?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix completion error about 'm' option of 'install' command
2018-07-19 5:02 ` Daniel Shahaf
@ 2018-07-19 5:43 ` Jun T
2018-07-19 7:40 ` dana
2018-07-19 8:00 ` Bart Schaefer
2 siblings, 0 replies; 5+ messages in thread
From: Jun T @ 2018-07-19 5:43 UTC (permalink / raw)
To: zsh-workers
> 2018/07/19 14:02、Daniel Shahaf <d.s@daniel.shahaf.name>のメール:
>
> This is a regression from 42214,
_flags is also renamed to _file_flags.
diff --git a/Completion/Unix/Command/_install b/Completion/Unix/Command/_install
index 4feb34ebf..80a1b0c00 100644
--- a/Completion/Unix/Command/_install
+++ b/Completion/Unix/Command/_install
@@ -41,7 +41,7 @@ else
args+=(
${common_args##((#s)|*\))(\*|)--*}
'-B+[specify backup suffix for -b]:backup suffix'
- '-f+[specify destination file flags]: :_flags'
+ '-f+[specify destination file flags]: :_file_flags'
)
[[ $OSTYPE == dragonfly* ]] && args+=(
'!-D+[no effect (compatibility with NetBSD)]: :_directories'
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix completion error about 'm' option of 'install' command
2018-07-19 5:02 ` Daniel Shahaf
2018-07-19 5:43 ` Jun T
@ 2018-07-19 7:40 ` dana
2018-07-19 8:00 ` Bart Schaefer
2 siblings, 0 replies; 5+ messages in thread
From: dana @ 2018-07-19 7:40 UTC (permalink / raw)
To: Daniel Shahaf; +Cc: Yasuhiro KIMURA, zsh-workers
On 19 Jul 2018, at 00:02, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>This is a regression from 42214, released in 5.5. Sounds like we might
>need a README/NEWS entry for this, as an incompatible change?
Oops, i'm sorry about that. The whole reason i wanted those broken out into
their own utility functions was so i could use them for _install... but i guess
i forgot to update the names when i submitted that next patch. :/
There shouldn't be any compatibility-breaking issues, though. Those functions
were renamed like the very next day after i first broke them out, so there was
never anything actually released where we used the old names. Any references to
them in other functions (like _find and _mkdir) were added at the same time.
dana
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix completion error about 'm' option of 'install' command
2018-07-19 5:02 ` Daniel Shahaf
2018-07-19 5:43 ` Jun T
2018-07-19 7:40 ` dana
@ 2018-07-19 8:00 ` Bart Schaefer
2 siblings, 0 replies; 5+ messages in thread
From: Bart Schaefer @ 2018-07-19 8:00 UTC (permalink / raw)
To: zsh-workers
On Wed, Jul 18, 2018 at 10:02 PM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> This is a regression from 42214, released in 5.5. Sounds like we might
> need a README/NEWS entry for this, as an incompatible change?
You mean we should have had such an entry regarding 42214 at the time
it was released?
Quite possibly.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-19 8:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-19 4:08 [PATCH] Fix completion error about 'm' option of 'install' command Yasuhiro KIMURA
2018-07-19 5:02 ` Daniel Shahaf
2018-07-19 5:43 ` Jun T
2018-07-19 7:40 ` dana
2018-07-19 8:00 ` Bart Schaefer
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).