[PATCH] Fix completion error about 'm' option of 'install' command

[PATCH] Fix completion error about 'm' option of 'install' command

[Yasuhiro KIMURA]

Hello,

I found following error happens while completing 'm' option of
'install' command.

yasu@rolling-vm-freebsd1[2016]% install -m_arguments:463: command not found: _modes                                        ~

And patch below fixes it.

diff --git a/Completion/Unix/Command/_install b/Completion/Unix/Command/_install
index f5056b5d0..4feb34ebf 100644
--- a/Completion/Unix/Command/_install
+++ b/Completion/Unix/Command/_install
@@ -11,7 +11,7 @@ common_args=(
   '(-C -c --compare)-c[copy files (default)]'
   '(-d --directory)'{-d,--directory}'[create directories]'
   '(-g --group)'{-g+,--group=}'[specify destination file group]: :_groups'
-  '(-m --mode)'{-m+,--mode=}'[specify destination file mode]: :_modes'
+  '(-m --mode)'{-m+,--mode=}'[specify destination file mode]: :_file_modes'
   '(-o --owner)'{-o+,--owner=}'[specify destination file owner]: :_users'
   '(-p --preserve-timestamps)'{-p,--preserve-timestamps}'[preserve modification times]'
   '(-s --strip)'{-s,--strip}'[strip binaries]'

Best Regards.

PS. Please CC to me because I don't subscribe this ML.

---
Yasuhiro KIMURA

Re: [PATCH] Fix completion error about 'm' option of 'install' command

[Daniel Shahaf]

Yasuhiro KIMURA wrote on Thu, 19 Jul 2018 13:08 +0900:
> I found following error happens while completing 'm' option of
> 'install' command.
> 
> yasu@rolling-vm-freebsd1[2016]% install -m_arguments:463: command not 
> found: _modes                                        ~
> 
> And patch below fixes it.
> 

Thank you for the patch; applied and pushed.

This is a regression from 42214, released in 5.5.  Sounds like we might
need a README/NEWS entry for this, as an incompatible change?

Re: [PATCH] Fix completion error about 'm' option of 'install' command

[Jun T]

> 2018/07/19 14:02、Daniel Shahaf <d.s@daniel.shahaf.name>のメール:
> 
> This is a regression from 42214,


_flags is also renamed to _file_flags. 


diff --git a/Completion/Unix/Command/_install b/Completion/Unix/Command/_install
index 4feb34ebf..80a1b0c00 100644
--- a/Completion/Unix/Command/_install
+++ b/Completion/Unix/Command/_install
@@ -41,7 +41,7 @@ else
   args+=(
     ${common_args##((#s)|*\))(\*|)--*}
     '-B+[specify backup suffix for -b]:backup suffix'
-    '-f+[specify destination file flags]: :_flags'
+    '-f+[specify destination file flags]: :_file_flags'
   )
   [[ $OSTYPE == dragonfly* ]] && args+=(
     '!-D+[no effect (compatibility with NetBSD)]: :_directories'

Re: [PATCH] Fix completion error about 'm' option of 'install' command

[dana]

On 19 Jul 2018, at 00:02, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>This is a regression from 42214, released in 5.5.  Sounds like we might
>need a README/NEWS entry for this, as an incompatible change?

Oops, i'm sorry about that. The whole reason i wanted those broken out into
their own utility functions was so i could use them for _install... but i guess
i forgot to update the names when i submitted that next patch. :/

There shouldn't be any compatibility-breaking issues, though. Those functions
were renamed like the very next day after i first broke them out, so there was
never anything actually released where we used the old names. Any references to
them in other functions (like _find and _mkdir) were added at the same time.

dana

Re: [PATCH] Fix completion error about 'm' option of 'install' command

[Bart Schaefer]

On Wed, Jul 18, 2018 at 10:02 PM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> This is a regression from 42214, released in 5.5.  Sounds like we might
> need a README/NEWS entry for this, as an incompatible change?

You mean we should have had such an entry regarding 42214 at the time
it was released?

Quite possibly.