zsh 5.6 doesn't get terminal size change information with "less"

zsh 5.6 doesn't get terminal size change information with "less"

[Vincent Lefevre]

Another major regression in zsh 5.6 and zsh 5.6.1 (tested with both
xterm and GNOME Terminal):

1. Open the terminal to some size.
2. View a file with "less" (do not quit).
3. Change the size of the terminal.
4. Quit "less".

The terminal becomes unusable (at least if the size has been reduced)
because zsh did not notice the change. If I echo $COLUMNS and $LINES,
they still have their old values.

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: zsh 5.6 doesn't get terminal size change information with "less"

[Peter Stephenson]

On Wed, 12 Sep 2018 02:44:21 +0200
Vincent Lefevre <vincent@vinc17.net> wrote:
> Another major regression in zsh 5.6 and zsh 5.6.1 (tested with both
> xterm and GNOME Terminal):
> 
> 1. Open the terminal to some size.
> 2. View a file with "less" (do not quit).
> 3. Change the size of the terminal.
> 4. Quit "less".
> 
> The terminal becomes unusable (at least if the size has been reduced)
> because zsh did not notice the change. If I echo $COLUMNS and $LINES,
> they still have their old values.

That attachtty() was new back in April --- it needs an
adjustwinsize() alongside it, like many of those in jobs.c.

pws

diff --git a/Src/signals.c b/Src/signals.c
index 20c6fdf..99aad0f 100644
--- a/Src/signals.c
+++ b/Src/signals.c
@@ -550,6 +550,7 @@ wait_for_processes(void)
 			 * leader, however.
 			 */
 			attachtty(mypgrp);
+			adjustwinsize(0);
 		    }
 		}
 	    }

Re: zsh 5.6 doesn't get terminal size change information with "less"

[Daniel Shahaf]

Peter Stephenson wrote on Wed, 12 Sep 2018 09:34 +0100:
> That attachtty() was new back in April --- it needs an
> adjustwinsize() alongside it, like many of those in jobs.c.

Sounds like a 5.6.2 is in order.  When shall that be cut?

Re: zsh 5.6 doesn't get terminal size change information with "less"

[Peter Stephenson]

On Wed, 12 Sep 2018 14:12:53 +0000
Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Peter Stephenson wrote on Wed, 12 Sep 2018 09:34 +0100:
> > That attachtty() was new back in April --- it needs an
> > adjustwinsize() alongside it, like many of those in jobs.c.  
> 
> Sounds like a 5.6.2 is in order.  When shall that be cut?

We could wait to the weekend, but I'm on holiday next week.

pws

Re: zsh 5.6 doesn't get terminal size change information with "less"

[Daniel Shahaf]

Peter Stephenson wrote on Wed, 12 Sep 2018 15:18 +0100:
> On Wed, 12 Sep 2018 14:12:53 +0000
> Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > Peter Stephenson wrote on Wed, 12 Sep 2018 09:34 +0100:
> > > That attachtty() was new back in April --- it needs an
> > > adjustwinsize() alongside it, like many of those in jobs.c.  
> > 
> > Sounds like a 5.6.2 is in order.  When shall that be cut?
> 
> We could wait to the weekend, but I'm on holiday next week.

Today and Fri both work for me.  For future reference, does anyone
besides you have upload access to zsh.org/pub/?

Re: zsh 5.6 doesn't get terminal size change information with "less"

[Peter Stephenson]

On Wed, 12 Sep 2018 14:24:29 +0000
Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Peter Stephenson wrote on Wed, 12 Sep 2018 15:18 +0100:
> > On Wed, 12 Sep 2018 14:12:53 +0000
> > Daniel Shahaf <d.s@daniel.shahaf.name> wrote:  
> > > Peter Stephenson wrote on Wed, 12 Sep 2018 09:34 +0100:  
> > > > That attachtty() was new back in April --- it needs an
> > > > adjustwinsize() alongside it, like many of those in jobs.c.    
> > > 
> > > Sounds like a 5.6.2 is in order.  When shall that be cut?  
> > 
> > We could wait to the weekend, but I'm on holiday next week.  
> 
> Today and Fri both work for me.  For future reference, does anyone
> besides you have upload access to zsh.org/pub/?

Better be Friday, but I won't get around to tidying up till somewhat
later.

I believe Bart has access, or used to.

pws

Re: zsh 5.6 doesn't get terminal size change information with "less"

[Bart Schaefer]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

On Wed, Sep 12, 2018, 7:40 AM Peter Stephenson <p.stephenson@samsung.com>
wrote:

> On Wed, 12 Sep 2018 14:24:29 +0000
> Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > Today and Fri both work for me.  For future reference, does anyone
> > besides you have upload access to zsh.org/pub/?
>
> I believe Bart has access, or used to.
>

I don't think I've ever had access to zsh.org, sorry.

Re: zsh 5.6 doesn't get terminal size change information with "less"

[Daniel Shahaf]

Peter Stephenson wrote on Wed, 12 Sep 2018 15:40 +0100:
> Better be Friday, but I won't get around to tidying up till
> somewhat later.

That's fine.  I'll tag/upload/announce on Fri and you can upload to
zsh.org after the announcement.