zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH v2 2/3] Fix the ':A' word modifier on paths with '..' components.
Date: Fri, 1 Jul 2016 09:05:29 -0700	[thread overview]
Message-ID: <160701090529.ZM9013@torch.brasslantern.com> (raw)
In-Reply-To: <20160701051106.GA31422@tarsus.local2>

On Jul 1,  5:11am, Daniel Shahaf wrote:
} Subject: Re: [PATCH v2 2/3] Fix the ':A' word modifier on paths with '..' 
}
} What's the use-case for the "resolve '..' before symlinks" behaviour?
} 
} Was it an intentional design feature, or simply a documented bug?
} (Honest question.)

PWS will have to weigh in on that one.  The use-case may simply have
been the intention to make :A a superset of :a.

} (Perhaps instead of a new option, a new syntax; e.g., have $foo:A retain
} its meaning and $foo:A:A have the new meaning.  Or make :A take an
} optional argument.)

Not ideal IMO because either would make :A differ from all other history
modifiers in this respect.  I.e. :A:A should mean to resolve to real
path and then resolve to real path again, like :h:h means to chop two
elements off the tail (and thus the second :A should be a no-op like
repeating :t); and no other has an optional argument.  However, worth
considering.

Sorry to just sort of leave things there.  I don't have a strong
objection to changing the :A default given the :a:A equivalence, and
that seems the least confusing final outcome if we conclude that the
likelihood of breaking scripts is small, but I would like to reach a
consensus decision.


  reply	other threads:[~2016-07-02  3:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10 17:36 [PATCH 1/3] Tests: Add tests for the ':a' and ':A' modifiers Daniel Shahaf
2016-06-10 17:36 ` [PATCH 2/3] Fix the ':A' word modifier on paths with '..' components Daniel Shahaf
2016-06-10 18:54   ` Mikael Magnusson
2016-06-10 19:46     ` Bart Schaefer
2016-06-12 14:28       ` Daniel Shahaf
2016-06-12 16:49         ` Bart Schaefer
2016-06-13  8:52           ` Daniel Shahaf
2016-06-21  1:53             ` [PATCH v2 1/3] Tests: Add tests for the ':a' and ':A' modifiers Daniel Shahaf
2016-06-21  1:53               ` [PATCH v2 2/3] Fix the ':A' word modifier on paths with '..' components Daniel Shahaf
2016-06-21  3:08                 ` Mikael Magnusson
2016-06-25 16:28                   ` Daniel Shahaf
2016-06-25 16:47                     ` Mikael Magnusson
2016-06-27  0:20                       ` Daniel Shahaf
2016-06-28 14:48                         ` Bart Schaefer
2016-07-01  5:11                           ` Daniel Shahaf
2016-07-01 16:05                             ` Bart Schaefer [this message]
2016-07-03 20:20                               ` Peter Stephenson
2016-07-05  4:57                               ` Daniel Shahaf
2016-06-21  1:53               ` [PATCH v2 3/3] Clean up chabspath() [':a' word modifier] Daniel Shahaf
2016-06-10 17:36 ` [PATCH " Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=160701090529.ZM9013@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).