From: Mikael Magnusson <mikachu@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh workers <zsh-workers@zsh.org>
Subject: Re: [PATCH v2 2/3] Fix the ':A' word modifier on paths with '..' components.
Date: Sat, 25 Jun 2016 18:47:58 +0200 [thread overview]
Message-ID: <CAHYJk3SrjHP3mT+c7xWH49ozhh18WHvLC5LRUzoZwWnkSSv8fA@mail.gmail.com> (raw)
In-Reply-To: <20160625162807.GA9840@tarsus.local2>
On Sat, Jun 25, 2016 at 6:28 PM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Mikael Magnusson wrote on Tue, Jun 21, 2016 at 05:08:16 +0200:
>> On Tue, Jun 21, 2016 at 3:53 AM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>> > The fix is to stop calling chabspath() at the top of chrealpath().
>> >
>> > Preserve the old behaviour when CHASE_DOTS is set.
>>
>> I think this is backwards, cd symlink/.. gets you to the current dir
>> if chasedots is unset, and to wherever symlink points' parent
>> directory when it is set.
>
> True.
>
> However, I don't want to just flip the condition (change "if isset()" to
> "if unset()") since I think the new behaviour (resolving symlinks before
> '..' components) should be the default for :A.
>
> So how about adding a new option and having chrealpath() use the new
> behaviour if the new option is at its default value, and the old
> (':a'-ish) behaviour otherwise?
That sounds pretty pointless, you would still break existing scripts,
and make everyone have to versioncheck to see if they have to enable
an option or not.
--
Mikael Magnusson
next prev parent reply other threads:[~2016-06-25 16:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 17:36 [PATCH 1/3] Tests: Add tests for the ':a' and ':A' modifiers Daniel Shahaf
2016-06-10 17:36 ` [PATCH 2/3] Fix the ':A' word modifier on paths with '..' components Daniel Shahaf
2016-06-10 18:54 ` Mikael Magnusson
2016-06-10 19:46 ` Bart Schaefer
2016-06-12 14:28 ` Daniel Shahaf
2016-06-12 16:49 ` Bart Schaefer
2016-06-13 8:52 ` Daniel Shahaf
2016-06-21 1:53 ` [PATCH v2 1/3] Tests: Add tests for the ':a' and ':A' modifiers Daniel Shahaf
2016-06-21 1:53 ` [PATCH v2 2/3] Fix the ':A' word modifier on paths with '..' components Daniel Shahaf
2016-06-21 3:08 ` Mikael Magnusson
2016-06-25 16:28 ` Daniel Shahaf
2016-06-25 16:47 ` Mikael Magnusson [this message]
2016-06-27 0:20 ` Daniel Shahaf
2016-06-28 14:48 ` Bart Schaefer
2016-07-01 5:11 ` Daniel Shahaf
2016-07-01 16:05 ` Bart Schaefer
2016-07-03 20:20 ` Peter Stephenson
2016-07-05 4:57 ` Daniel Shahaf
2016-06-21 1:53 ` [PATCH v2 3/3] Clean up chabspath() [':a' word modifier] Daniel Shahaf
2016-06-10 17:36 ` [PATCH " Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHYJk3SrjHP3mT+c7xWH49ozhh18WHvLC5LRUzoZwWnkSSv8fA@mail.gmail.com \
--to=mikachu@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).