From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Fix a bunch of Coverity-reported defects
Date: Thu, 26 Oct 2023 09:28:29 +0100 (BST) [thread overview]
Message-ID: <1916212035.1566877.1698308909875@mail.virginmedia.com> (raw)
In-Reply-To: <CAH+w=7a88XNokfYdU4kfbNUAOn_bPPYw1zoRR0im-js_xRWwHQ@mail.gmail.com>
> On 26/10/2023 04:36 Bart Schaefer <schaefer@brasslantern.com> wrote:
> A batch of the warnings that I ignored were assignments of one field
> of a union to another field of the same union, e.g., a casted long
> onto a double, etc., which elicited "overlapping copy" warnings. I'm
> fairly confident we'd have seen things crashing by now if this wasn't
> safe, but I mention it in case someone knows why it might be a
> problem.
I guess it's worried about cases where the reads are not atomic
and you might be writing back piecemeal. I can't believe this is going
to be an issue for 32-bit values, so if there was ever going to be a
problem it would be when there is a read of e.g. a long long or a double
on a 32-bit system. I rather suspect compiler writers are alive to this
sort of thing anyway.
pws
next prev parent reply other threads:[~2023-10-26 8:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 3:36 Bart Schaefer
2023-10-26 8:19 ` Mikael Magnusson
2023-10-26 14:25 ` Bart Schaefer
2023-10-26 14:42 ` zeurkous
2023-10-26 8:28 ` Peter Stephenson [this message]
2023-10-26 9:19 ` Roman Perepelitsa
2023-10-26 14:05 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1916212035.1566877.1698308909875@mail.virginmedia.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).