From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Fix a bunch of Coverity-reported defects
Date: Thu, 26 Oct 2023 10:19:07 +0200 [thread overview]
Message-ID: <CAHYJk3TE5cQ+f8=mvvQ=CxppfMRKhRh2boz7PWRyoexFWcrSYQ@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7a88XNokfYdU4kfbNUAOn_bPPYw1zoRR0im-js_xRWwHQ@mail.gmail.com>
On 10/26/23, Bart Schaefer <schaefer@brasslantern.com> wrote:
> I triaged about 85 defects in the Coverity scan UI. The majority of
> them were spurious, and I marked them "Ignore".
One thing to keep in mind is it sometimes groups several "occurrences"
of the same issue together, you can switch them with a combo box near
the bottom right of the UI. (maybe a bit late to point this out now).
I've sometimes noticed that the first instance is a false positive
while one of the others are not, but that was years ago, maybe they've
improved this.
> There were 14 that I
> felt worthy of small fixes; those are included in the patch below. I
> believe that leaves 14 others where I wasn't confident of a fix;
> several of them are in zftp, as I recall.
>
> A batch of the warnings that I ignored were assignments of one field
> of a union to another field of the same union, e.g., a casted long
> onto a double, etc., which elicited "overlapping copy" warnings. I'm
> fairly confident we'd have seen things crashing by now if this wasn't
> safe, but I mention it in case someone knows why it might be a
> problem.
>
> One of those I did NOT fix is this, mentioned recently:
>
>> > *** CID 1547827: Null pointer dereferences (FORWARD_NULL)
>> > /Src/Modules/pcre.c: 370 in bin_pcre_match()
>> > >>> Passing null pointer "named" to "zpcre_get_substrings", which
>> > >>> dereferences it.
>>
>> This is from Oliver's 51738 (PCRE's alternative DFA), I'm not going to
>> interpret futher.
>
> Let me know if there's anything controversial here.
I uploaded a new build to coverity with this patch applied and it
seems to be happy with it.
--
Mikael Magnusson
next prev parent reply other threads:[~2023-10-26 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 3:36 Bart Schaefer
2023-10-26 8:19 ` Mikael Magnusson [this message]
2023-10-26 14:25 ` Bart Schaefer
2023-10-26 14:42 ` zeurkous
2023-10-26 8:28 ` Peter Stephenson
2023-10-26 9:19 ` Roman Perepelitsa
2023-10-26 14:05 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3TE5cQ+f8=mvvQ=CxppfMRKhRh2boz7PWRyoexFWcrSYQ@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).