From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Fix a bunch of Coverity-reported defects
Date: Thu, 26 Oct 2023 07:05:29 -0700 [thread overview]
Message-ID: <CAH+w=7YiJ6_ceji8kBk4Ou2KFJOi+AJ4xCj-_FRn+qZr-hu0Bg@mail.gmail.com> (raw)
In-Reply-To: <CAN=4vMoHJKmUy7yyGv7b9L5U_LR4JPPtLLuJ8Xt1vEdBw5LQWw@mail.gmail.com>
On Thu, Oct 26, 2023 at 2:19 AM Roman Perepelitsa
<roman.perepelitsa@gmail.com> wrote:
>
> On Thu, Oct 26, 2023 at 5:37 AM Bart Schaefer <schaefer@brasslantern.com> wrote:
> >
> > A batch of the warnings that I ignored were assignments of one field
> > of a union to another field of the same union, e.g., a casted long
> > onto a double, etc., which elicited "overlapping copy" warnings.
>
> This can indeed cause problems. The conditions under which it happens
> are subtle. Here's an example: https://godbolt.org/z/EvxTzM1hn.
>
> inline int foo(int* x, float* y) {
> *x = 1;
> *y = 2;
> return *x;
> }
None of the instances flagged by coverity involved indirection through
pointers, so I suspect we're OK there.
prev parent reply other threads:[~2023-10-26 14:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 3:36 Bart Schaefer
2023-10-26 8:19 ` Mikael Magnusson
2023-10-26 14:25 ` Bart Schaefer
2023-10-26 14:42 ` zeurkous
2023-10-26 8:28 ` Peter Stephenson
2023-10-26 9:19 ` Roman Perepelitsa
2023-10-26 14:05 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YiJ6_ceji8kBk4Ou2KFJOi+AJ4xCj-_FRn+qZr-hu0Bg@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).