* PATCH: nitpick
@ 2005-07-24 3:12 Clint Adams
2005-07-24 5:16 ` Bart Schaefer
0 siblings, 1 reply; 3+ messages in thread
From: Clint Adams @ 2005-07-24 3:12 UTC (permalink / raw)
To: zsh-workers
I'm trying to figure out whether the Scripts directory should be created
by 'make install' or whether it should not be in $fpath. So I changed
this instead.
Index: Config/installfns.sh
===================================================================
RCS file: /cvsroot/zsh/zsh/Config/installfns.sh,v
retrieving revision 1.11
diff -u -r1.11 installfns.sh
--- Config/installfns.sh 20 Jul 2005 18:08:53 -0000 1.11
+++ Config/installfns.sh 24 Jul 2005 03:05:30 -0000
@@ -17,7 +17,7 @@
case "$file" in
*/CVS/*) continue;;
esac
- if test x$FUNCTIONS_SUBDIRS != x -a x$FUNCTIONS_SUBDIRS != xno; then
+ if test x$FUNCTIONS_SUBDIRS != x && test x$FUNCTIONS_SUBDIRS != xno; then
case "$file" in
Completion/*/*)
subdir="`echo $file | sed -e 's%/[^/]*/[^/]*$%%'`"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: nitpick
2005-07-24 3:12 PATCH: nitpick Clint Adams
@ 2005-07-24 5:16 ` Bart Schaefer
2005-07-24 12:59 ` Clint Adams
0 siblings, 1 reply; 3+ messages in thread
From: Bart Schaefer @ 2005-07-24 5:16 UTC (permalink / raw)
To: zsh-workers
On Jul 23, 11:12pm, Clint Adams wrote:
}
} I'm trying to figure out whether the Scripts directory should be created
} by 'make install' or whether it should not be in $fpath. So I changed
} this instead.
Maybe it's just because I'm tired, but I don't understand what the
functional difference is? Other than the xtrace output ...
} - if test x$FUNCTIONS_SUBDIRS != x -a x$FUNCTIONS_SUBDIRS != xno
} + if test x$FUNCTIONS_SUBDIRS != x && test x$FUNCTIONS_SUBDIRS != xno
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: nitpick
2005-07-24 5:16 ` Bart Schaefer
@ 2005-07-24 12:59 ` Clint Adams
0 siblings, 0 replies; 3+ messages in thread
From: Clint Adams @ 2005-07-24 12:59 UTC (permalink / raw)
To: Bart Schaefer; +Cc: zsh-workers
> Maybe it's just because I'm tired, but I don't understand what the
> functional difference is? Other than the xtrace output ...
It's a /bin/sh script, so the existence of the binary -a is not
guaranteed, and if the expression were more complex, the operator
precedence could be ambiguous too.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-07-24 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-07-24 3:12 PATCH: nitpick Clint Adams
2005-07-24 5:16 ` Bart Schaefer
2005-07-24 12:59 ` Clint Adams
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).