Locale related problem with zshrc parsing

Locale related problem with zshrc parsing

[Ismail Dönmez]

Hi all,

zsh seems to be affected by infamous Turkish locale (LC_ALL=tr_TR.UTF-8) 
problem. In Turkish lowercase of "I" is not i but its ı (i-dotless). And this 
seems to affect zsh too :

[~]> zsh --version
zsh 4.3.2-dev-1 (i686-pc-linux-gnu)

[~]> setopt SHARE_HISTORY
setopt: no such option: SHARE_HISTORY

[~]> setopt share_history
[~]>

As you can see any option having "I" in it won't work on Turkish. I reproduced 
the problem with zsh 4.3.2 and latest CVS.

Regards.

-- 
Happiness in intelligent people is the rarest thing I know. (Ernest Hemingway)

Ismail Donmez ismail (at) pardus.org.tr
GPG Fingerprint: 7ACD 5836 7827 5598 D721 DF0D 1A9D 257A 5B88 F54C
Pardus Linux / KDE developer

Re: Locale related problem with zshrc parsing

[Peter Stephenson]

Ismail Dönmez <ismail@pardus.org.tr> wrote:
> zsh seems to be affected by infamous Turkish locale (LC_ALL=tr_TR.UTF-8)
> problem. In Turkish lowercase of "I" is not i but its ı (i-dotless). And
> this seems to affect zsh too :
> 
> [~]> zsh --version
> zsh 4.3.2-dev-1 (i686-pc-linux-gnu)
> 
> [~]> setopt SHARE_HISTORY
> setopt: no such option: SHARE_HISTORY

Thanks, I've fixed this occurrence but you may see similar things
occurring from other places in the code.

Index: Src/options.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/options.c,v
retrieving revision 1.34
diff -u -r1.34 options.c
--- Src/options.c	6 Feb 2007 21:47:55 -0000	1.34
+++ Src/options.c	15 Mar 2007 14:32:42 -0000
@@ -603,7 +603,14 @@
 	if (*t == '_')
 	    chuck(t);
 	else {
-	    *t = tulower(*t);
+	    /*
+	     * Some locales (in particular tr_TR.UTF-8) may
+	     * have non-standard mappings of ASCII characters,
+	     * so be careful.  Option names must be ASCII so
+	     * we don't need to be too clever.
+	     */
+	    if (*t >= 'A' && *t <= 'Z')
+		*t = (*t - 'A') + 'a';
 	    t++;
 	}
 


-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php

To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview

Re: Locale related problem with zshrc parsing

[Ismail Dönmez]

On Thursday 15 March 2007 16:43:51 Peter Stephenson wrote:
> Ismail Dönmez <ismail@pardus.org.tr> wrote:
> > zsh seems to be affected by infamous Turkish locale (LC_ALL=tr_TR.UTF-8)
> > problem. In Turkish lowercase of "I" is not i but its ı (i-dotless). And
> > this seems to affect zsh too :
> >
> > [~]> zsh --version
> > zsh 4.3.2-dev-1 (i686-pc-linux-gnu)
> >
> > [~]> setopt SHARE_HISTORY
> > setopt: no such option: SHARE_HISTORY
>
> Thanks, I've fixed this occurrence but you may see similar things
> occurring from other places in the code.

Thanks for the fast fix, I'll report if I see any related problem elsewhere.

Regards.
-- 
Happiness in intelligent people is the rarest thing I know. (Ernest Hemingway)

Ismail Donmez ismail (at) pardus.org.tr
GPG Fingerprint: 7ACD 5836 7827 5598 D721 DF0D 1A9D 257A 5B88 F54C
Pardus Linux / KDE developer