Re: Bug#431437: zsh: 'svn {ci, commit}' completion includes uncontrolled/unmodified files

Re: Bug#431437: zsh: 'svn {ci, commit}' completion includes uncontrolled/unmodified files

[Clint Adams]

On Mon, Jul 02, 2007 at 10:19:52AM -0500, Michael Ekstrand wrote:
> The completion routines for arguments to the subversion commit command
> allow completion of uncontrolled and unmodified files.  These files do
> not show up in the list of available completions when Tab is hit twice,
> but they are completed when typed.
> 
> To reproduce, place a new file in a Subversion working directory and
> attempt to tab-complete for svn ci without first adding it to the
> repository.
> 
> With the exception of the argument to the -F option (which will usually
> be uncontrolled), I think that the commit completion should be
> restricted to modified files under version control.

Any svn users have any thoughts on this one?

Re: Bug#431437: zsh: 'svn {ci, commit}' completion includes uncontrolled/unmodified files

[Ismail Dönmez]

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

On Monday 02 July 2007 18:35:28 Clint Adams wrote:
> On Mon, Jul 02, 2007 at 10:19:52AM -0500, Michael Ekstrand wrote:
> > The completion routines for arguments to the subversion commit command
> > allow completion of uncontrolled and unmodified files.  These files do
> > not show up in the list of available completions when Tab is hit twice,
> > but they are completed when typed.
> >
> > To reproduce, place a new file in a Subversion working directory and
> > attempt to tab-complete for svn ci without first adding it to the
> > repository.
> >
> > With the exception of the argument to the -F option (which will usually
> > be uncontrolled), I think that the commit completion should be
> > restricted to modified files under version control.
>
> Any svn users have any thoughts on this one?

As an SVN user I agree with the original reporter.

Regards,
ismail

-- 
Perfect is the enemy of good

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: Bug#431437: zsh: 'svn {ci, commit}' completion includes uncontrolled/unmodified files

[Wayne Davison]

On Mon, Jul 02, 2007 at 10:19:52AM -0500, Michael Ekstrand wrote:
> The completion routines for arguments to the subversion commit command
> allow completion of uncontrolled and unmodified files.  These files do
> not show up in the list of available completions when Tab is hit twice,
> but they are completed when typed.

This sounds like the normal zsh behavior for ignored files; e.g:

zsh -f
fignore=(.old)
touch foo foobar.old

ls fo<TAB> completes "foo"

ls foob<TAB> completes "foobar.old" (since there are no non-ignored
completions that are possible)

If it is possible to change this behavior, I don't know about how.
Anyone else know?

..wayne..

Re: Bug#431437: zsh: 'svn {ci, commit}' completion includes uncontrolled/unmodified files

[Peter Stephenson]

On Mon, 2 Jul 2007 11:55:00 -0700
Wayne Davison <wayned@users.sourceforge.net> wrote:
> This sounds like the normal zsh behavior for ignored files; e.g:
> 
> zsh -f
> fignore=(.old)
> touch foo foobar.old
> 
> ls fo<TAB> completes "foo"
> 
> ls foob<TAB> completes "foobar.old" (since there are no non-ignored
> completions that are possible)
> 
> If it is possible to change this behavior, I don't know about how.
> Anyone else know?

Removing the _ignored completer turns this off globally, but that's
probably not what you want.  Setting ignored-patterns to empty for the
context in question might be better.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070


To access the latest news from CSR copy this link into a web browser:  http://www.csr.com/email_sig.php

To get further information regarding CSR, please visit our Investor Relations page at http://ir.csr.com/csr/about/overview

Re: Bug#431437: zsh: 'svn {ci, commit}' completion includes uncontrolled/unmodified files

[Jörg Sommer]

Hi,

Clint Adams <schizo@debian.org> wrote:
> On Mon, Jul 02, 2007 at 10:19:52AM -0500, Michael Ekstrand wrote:
>> The completion routines for arguments to the subversion commit command
>> allow completion of uncontrolled and unmodified files.  These files do
>> not show up in the list of available completions when Tab is hit twice,
>> but they are completed when typed.
>> 
>> To reproduce, place a new file in a Subversion working directory and
>> attempt to tab-complete for svn ci without first adding it to the
>> repository.
>> 
>> With the exception of the argument to the -F option (which will usually
>> be uncontrolled), I think that the commit completion should be
>> restricted to modified files under version control.
>
> Any svn users have any thoughts on this one?

I can confirm this behaviour and I like it. The svn completion maintains
an internal cache that really often get outdated. Than the completion of
these files is very handy.

Bye, Jörg.
-- 
MCSE = Minesweeper Consultant & Solitaire Expert

Re: Bug#431437: zsh: 'svn {ci, commit}' completion includes uncontrolled/unmodified files

[Vincent Lefevre]

On 2007-07-03 12:07:05 +0000, Jörg Sommer wrote:
> Clint Adams <schizo@debian.org> wrote:
> > On Mon, Jul 02, 2007 at 10:19:52AM -0500, Michael Ekstrand wrote:
> >> The completion routines for arguments to the subversion commit command
> >> allow completion of uncontrolled and unmodified files.  These files do
> >> not show up in the list of available completions when Tab is hit twice,
> >> but they are completed when typed.

I've noticed the same problem (or similar).

> I can confirm this behaviour and I like it. The svn completion maintains
> an internal cache that really often get outdated. Than the completion of
> these files is very handy.

But this is because that cache gets outdated, which is a bug (IIRC,
cvs completion is fast and non-buggy). zsh should complete only the
modified files for "svn ci" when the completion list is not empty.

-- 
Vincent Lefèvre <vincent@vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / Arenaire project (LIP, ENS-Lyon)