git-svn completion doesn't work

git-svn completion doesn't work

[Mikael Magnusson]

git-svn <tab> says "no match for: `command'" instead of completing
commands, not sure why. git-svn fetch <tab> said
_git-svn:154: command not found: (-i --id)-i[set GIT_SVN_ID]:GIT_SVN_ID
which I could fix with

@@ -2472,7 +2472,7 @@ _git-svn () {
         '(-h -H --help)'{-h,-H,--help}'[display usage information]' \
         '(-V --version)'{-V,--version}'[display version information]' \
         '--minimize-connections[undocumented]' \
-        '(-R --svn-remote --remote)'{-R,--svn-remote,--remote}'[svn
remote to use]:svn remote:__git_svn-remotes'
+        '(-R --svn-remote --remote)'{-R,--svn-remote,--remote}'[svn
remote to use]:svn remote:__git_svn-remotes' \
         '(-i --id)'{-i,--id}'[set GIT_SVN_ID]:GIT_SVN_ID'
         $arguments && ret=0

however, then it moved on to saying
_git-svn:155: command not found: --username=[username to use for SVN
transport]:username:_users

and I have no idea why it does that. I also believe this change should
be done but not sure:

@@ -2357,8 +2357,8 @@ _git-svn () {

       if [[ $line[1] == (fetch|clone|dcommit|set-tree|rebase|log) ]]; then
         arguments+=(
-          '(   --authors-file)'$author_conversion_file_arg
-          '(-A               )'$long_author_conversion_file_arg)
+          '(   --authors-file)'$long_author_conversion_file_arg
+          '(-A               )'$author_conversion_file_arg)
       fi

       # TODO: --repack-flags can be improved by actually completing the legal


-- 
Mikael Magnusson

Re: git-svn completion doesn't work

[Clint Adams]

On Fri, Oct 05, 2007 at 04:26:05PM +0200, Mikael Magnusson wrote:
> @@ -2472,7 +2472,7 @@ _git-svn () {
>          '(-h -H --help)'{-h,-H,--help}'[display usage information]' \
>          '(-V --version)'{-V,--version}'[display version information]' \
>          '--minimize-connections[undocumented]' \
> -        '(-R --svn-remote --remote)'{-R,--svn-remote,--remote}'[svn
> remote to use]:svn remote:__git_svn-remotes'
> +        '(-R --svn-remote --remote)'{-R,--svn-remote,--remote}'[svn
> remote to use]:svn remote:__git_svn-remotes' \
>          '(-i --id)'{-i,--id}'[set GIT_SVN_ID]:GIT_SVN_ID'
>          $arguments && ret=0

Committed.

> however, then it moved on to saying
> _git-svn:155: command not found: --username=[username to use for SVN
> transport]:username:_users

Try this.

Index: Completion/Unix/Command/_git
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_git,v
retrieving revision 1.42
diff -u -r1.42 _git
--- Completion/Unix/Command/_git	6 Oct 2007 00:48:15 -0000	1.42
+++ Completion/Unix/Command/_git	6 Oct 2007 00:54:33 -0000
@@ -2473,7 +2473,7 @@
         '(-V --version)'{-V,--version}'[display version information]' \
         '--minimize-connections[undocumented]' \
         '(-R --svn-remote --remote)'{-R,--svn-remote,--remote}'[svn remote to use]:svn remote:__git_svn-remotes' \
-        '(-i --id)'{-i,--id}'[set GIT_SVN_ID]:GIT_SVN_ID'
+        '(-i --id)'{-i,--id}'[set GIT_SVN_ID]:GIT_SVN_ID' \
         $arguments && ret=0
 
       case $state in

> and I have no idea why it does that. I also believe this change should
> be done but not sure:

I don't think so.