uuid module out-of-tree

uuid module out-of-tree

[Clint Adams]

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

Attached is my latest stab at an out-of-tree module.

This one is simple and links to libuuid from e2fsprogs, using header
files from zsh 4.3.4.

To use, build and load the module, then run 'zuuid' and it will output a
128-bit universally unique ID (per RFC 4122).

config.h and zsh.mdh are munged from a zsh 4.3.4 build, which is
suboptimal.

uuid.mdh (in the tarball, "hand-crafted") includes zsh.mdh, zsh.mdh
includes system.h, and system.h needs config.h .

One thing to do would be to ship some kind of include file for autoconf
so that the out-of-tree module can set all the necessary defines
(such as HAVE_STDARG_H or HAVE_VARARGS_H) needed by system.h

Alternately, the portions of system.h that require config.h but don't
need to be exported for out-of-tree modules could be split out to
a different header or guarded with #ifdefs.

[-- Attachment #2: libuuid-zsh-0.0.tar.gz --]
[-- Type: application/octet-stream, Size: 258410 bytes --]

Re: uuid module out-of-tree

[Clint Adams]

On Thu, Oct 11, 2007 at 10:44:28AM -0400, Clint Adams wrote:
> One thing to do would be to ship some kind of include file for autoconf
> so that the out-of-tree module can set all the necessary defines
> (such as HAVE_STDARG_H or HAVE_VARARGS_H) needed by system.h
> 
> Alternately, the portions of system.h that require config.h but don't
> need to be exported for out-of-tree modules could be split out to
> a different header or guarded with #ifdefs.

With the following aczshoot.m4 function (included from acinclude.m4)

AC_DEFUN(zsh_OOT,
[
AC_CHECK_HEADERS(stdarg.h varargs.h termios.h termio.h)

AC_TYPE_SIGNAL

AC_DEFINE([ZSH_OOT_MODULE], [], [Out-of-tree module])
])

and the following patch, the complete config.h is unnecessary.  The uuid
module doesn't need stdarg.h, varargs.h, termios.h, termio.h, or
RETSIGTYPE, however.  Any thoughts?

diff --git a/Src/system.h b/Src/system.h
index 781a907..022ace2 100644
--- a/Src/system.h
+++ b/Src/system.h
@@ -225,7 +225,7 @@ char *alloca _((size_t));
 #endif
 
 /* This is needed by some old SCO unices */
-#ifndef HAVE_STRUCT_TIMEZONE
+#if !defined(HAVE_STRUCT_TIMEZONE) && !defined(ZSH_OOT_MODULE)
 struct timezone {
     int tz_minuteswest;
     int tz_dsttime;

Re: uuid module out-of-tree

[Peter Stephenson]

On Thu, 11 Oct 2007 11:08:11 -0400
Clint Adams <clint@zsh.org> wrote:
> On Thu, Oct 11, 2007 at 10:44:28AM -0400, Clint Adams wrote:
> > One thing to do would be to ship some kind of include file for autoconf
> > so that the out-of-tree module can set all the necessary defines
> > (such as HAVE_STDARG_H or HAVE_VARARGS_H) needed by system.h
> > 
> > Alternately, the portions of system.h that require config.h but don't
> > need to be exported for out-of-tree modules could be split out to
> > a different header or guarded with #ifdefs.
> 
> With the following aczshoot.m4 function (included from acinclude.m4)
> 
> AC_DEFUN(zsh_OOT,
> [
> AC_CHECK_HEADERS(stdarg.h varargs.h termios.h termio.h)
> 
> AC_TYPE_SIGNAL
> 
> AC_DEFINE([ZSH_OOT_MODULE], [], [Out-of-tree module])
> ])
> 
> and the following patch, the complete config.h is unnecessary.  The uuid
> module doesn't need stdarg.h, varargs.h, termios.h, termio.h, or
> RETSIGTYPE, however.  Any thoughts?

It looks unobtrusive enough we could do that for now and change it if we
think of something better.  I haven't really go my mind around the
requirements for doing this properly, however.

I think it's worth keeping zcurses in the distribution anyway.  It
would be quite a nice addition to compinstall and zsh-install-newuser
(with a function front-end).

-- 
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/

Re: uuid module out-of-tree

[Clint Adams]

On Thu, Oct 11, 2007 at 08:23:01PM +0100, Peter Stephenson wrote:
> It looks unobtrusive enough we could do that for now and change it if we
> think of something better.  I haven't really go my mind around the
> requirements for doing this properly, however.

I'll commit the one-liner to Src/system.h.  Where would be a good place
to ship the .m4 file? Etc/ ? Config/ ? Misc/ ?

> I think it's worth keeping zcurses in the distribution anyway.  It
> would be quite a nice addition to compinstall and zsh-install-newuser
> (with a function front-end).

I agree and hope someone can tell me what I've done wrong with -s.

Re: uuid module out-of-tree

[Peter Stephenson]

Clint Adams wrote:
> On Thu, Oct 11, 2007 at 08:23:01PM +0100, Peter Stephenson wrote:
> > It looks unobtrusive enough we could do that for now and change it if we
> > think of something better.  I haven't really go my mind around the
> > requirements for doing this properly, however.
> 
> I'll commit the one-liner to Src/system.h.  Where would be a good place
> to ship the .m4 file? Etc/ ? Config/ ? Misc/ ?

Config sounds appropriate.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: uuid module out-of-tree

[Clint Adams]

On Fri, Oct 12, 2007 at 09:50:45AM +0100, Peter Stephenson wrote:
> Config sounds appropriate.

Okay, so I will do something like the following when constructing the
headers package (assuming obj/ is the build directory).

        $(INSTALL_FILE) obj/Src/*.epro obj/Src/sigcount.h \
                        Src/hashtable.h Src/prototypes.h \
                        Src/signals.h Src/system.h Src/zsh.h Src/ztype.h \
                        /usr/include/zsh
        $(INSTALL_FILE) Src/makepro.awk /usr/share/zsh-dev
        $(INSTALL_FILE) Config/aczshoot.m4 /usr/share/aclocal/zshoot.m4

I'll tweak the uuid build to use the new file and share some of my thoughts
on goals and progress and such in a bit.

Index: Config/aczshoot.m4
===================================================================
RCS file: Config/aczshoot.m4
diff -N Config/aczshoot.m4
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ Config/aczshoot.m4	12 Oct 2007 12:29:48 -0000
@@ -0,0 +1,8 @@
+AC_DEFUN(zsh_OOT,
+[
+AC_CHECK_HEADERS(stdarg.h varargs.h termios.h termio.h)
+
+AC_TYPE_SIGNAL
+
+AC_DEFINE([ZSH_OOT_MODULE], [], [Out-of-tree module])
+])