Re: 4.3.4-dev-8

Re: 4.3.4-dev-8

[Bart Schaefer]

[Moved to -workers]

On Jan 29, 11:43am, Peter Stephenson wrote:
}
} If you get a chance to look at the documentation let me know if there is
} anything obviously broken there.

I'd never noticed this before, but "2.7 The Zsh Wiki" is not its own
info node; it doesn't get put on a new page like 2.4, 2.5, and 2.8,
it's on the same page as 2.6.

Of course *none* of the sub-sections of chapters 3, 5, 7, and 9 get
their own nodes/pages, either, although every section of chapter 4 and
6 does.  What is it with odd-numbered chapters?  (Chapter 8 has only
one section, so it doesn't count.)  Oh, 10 has no nodes for sections.

The section numbers in chapter 13 (Prompt Expansion) are wrong, they
start with 13.0.1, 13.0.2, etc., rather than 13.1, 13.2.  And they
predictably don't have their own nodes.

Chapter 14 (Expansion) has a new node/page for every section *and* a
new node/page for every sub-section of 14.1 (History), but does not
have a new node/page for sub-sections of 14.3 (Parameter) or 14.8
(Filename), even though both of those sections are longer than the
section on History.

Someone appears to have mistaken 15 and 19 for even numbers.  This is
not really a problem.

Sections 18.5 and 18.6 do not have nodes/pages even though the other
chapter 18 sections do.  This is particularly bad because 18.6 has a
menu of sub-sections which all get their own nodes, so invoking the
menu in 18.4 gets you the 18.6 sub-sections.  The heading of 18.5.1
is "Special Widget" from the days when zle-line-init was the only one,
but it should probably be plural now.

Chapter 21 looks like it's going to have the 18.6 problem, but then it
turns out that the menu under 21.2 is really for 21.3 through 21.7,
so that's a completely different oddity.

Section 22.23 (zsh/system Builtins) should be 22.22.1, and similarly
for 22.24 / 22.22.2, so all numbering from 22.25 on is out of whack.

24.3 (TCP User Defined Functions) should either be 24.2.5 or should
have its own node and appear in the menu under 24.  Similarly for
24.4 (TCP Utility Functions) / 24.2.6.  Numbers of the succeeding
sections are off if these should not be nodes.  24.6 and 24.7 have
the same problem, they should be 24.5.1 and 24.5.2 (or 24.3.1 and
24.3.2 if the previous problem is fixed, I think).

That's it for structural problems; I don't have time to proofread now.

Re: 4.3.4-dev-8

[Peter Stephenson]

On Tue, 29 Jan 2008 09:12:18 -0800
Bart Schaefer <schaefer@brasslantern.com> wrote:
> The section numbers in chapter 13 (Prompt Expansion) are wrong, they
> start with 13.0.1, 13.0.2, etc., rather than 13.1, 13.2.

This appears to be sort of deliberate, because the chapter would have just
one section (as the manual does, but chapters appear to be irrelevant to it)
but we can fudge the issue by generating proper sectioning.  This
divides the manual up a bit more but I don't think that's a problem.

> The heading of 18.5.1
> is "Special Widget" from the days when zle-line-init was the only one,
> but it should probably be plural now.

I've changed this, but if anyone wants the nodes and sections of the entire
document realigned any time soon they'll have to volunteer for it.

Index: Doc/Zsh/prompt.yo
===================================================================
RCS file: /cvsroot/zsh/zsh/Doc/Zsh/prompt.yo,v
retrieving revision 1.8
diff -u -r1.8 prompt.yo
--- Doc/Zsh/prompt.yo	1 Apr 2005 12:04:23 -0000	1.8
+++ Doc/Zsh/prompt.yo	29 Jan 2008 17:30:00 -0000
@@ -1,8 +1,6 @@
 texinode(Prompt Expansion)(Expansion)(Conditional Expressions)(Top)
 chapter(Prompt Expansion)
-ifzman(\
-sect(Prompt Expansion)
-)\
+sect(Expansion of Prompt Sequences)
 cindex(prompt expansion)
 cindex(expansion, prompt)
 Prompt sequences undergo a special form of expansion.  This type of expansion
@@ -31,9 +29,13 @@
 pindex(PROMPT_PERCENT, use of)
 If the tt(PROMPT_PERCENT) option is set, certain escape sequences that
 start with `tt(%)' are expanded.
-Some escapes take an optional integer argument, which
+Many escapes are followed by a single character, although some of these
+take an optional integer argument that
 should appear between the `tt(%)' and the next character of the
-sequence.  The following escape sequences are recognized:
+sequence.  More complicated escape sequences are available to provide
+conditional expansion.
+
+sect(Simple Prompt Escapes)
 
 subsect(Special characters)
 startitem()
@@ -188,7 +190,7 @@
 )
 enditem()
 
-subsect(Conditional substrings)
+sect(Conditional Substrings in Prompts)
 startitem()
 item(tt(%v))(
 vindex(psvar, use of)
Index: Doc/Zsh/zle.yo
===================================================================
RCS file: /cvsroot/zsh/zsh/Doc/Zsh/zle.yo,v
retrieving revision 1.57
diff -u -r1.57 zle.yo
--- Doc/Zsh/zle.yo	10 Nov 2007 14:30:23 -0000	1.57
+++ Doc/Zsh/zle.yo	29 Jan 2008 17:30:01 -0000
@@ -784,7 +784,7 @@
 )
 enditem()
 
-subsect(Special Widget)
+subsect(Special Widgets)
 
 There are a few user-defined widgets which are special to the shell.
 If they do not exist, no special action is taken.  The environment


-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: 4.3.4-dev-8

[Peter Stephenson]

On Tue, 29 Jan 2008 19:04:16 +0200
"Zvi Har'El" <rl@math.technion.ac.il> wrote:
> I would like to remind you that on solaris syestem, where ncursesw 
> installed in /usr/local and needs /usr/local/include/ncursesw/term.h 
> rather than /usr/include/term.h, normal build fails, and I need to run 
> "*CFLAGS=-I/usr/local/include/ncursesw ./configure*".

Ick.  I wasn't aware there were yet more problems after the zillion zillion
zillion little hacks for ncurses libraries.

In the long run it ought to be possible to move the configuration code for
term further down until we've probed for variants of curses and have some
idea what libraries we're using; that's more logical anyway since the code
includes curses.h which we may not actually be using.

We also have a perennial warning on Solaris from configure that it doesn't
like term.h (because it needs curses.h---which is what we're testing for,
but configure doesn't like us doing it that way) and that future versions
of autoconf may just go into a sulk.

For now here's a note.

Index: INSTALL
===================================================================
RCS file: /cvsroot/zsh/zsh/INSTALL,v
retrieving revision 1.33
diff -u -r1.33 INSTALL
--- INSTALL	20 Nov 2007 14:20:00 -0000	1.33
+++ INSTALL	29 Jan 2008 17:38:52 -0000
@@ -336,6 +336,11 @@
 configure.  Similarly, you may need to pass LDFLAGS=-L/usr/local/lib
 (or wherever) in order to find the library.
 
+You may also need to add headers if you need to include the file term.h
+from an installation of an ncurses variant instead of from the system
+directories.  For example, CPPFLAGS=-I/usr/local/include/ncursesw will
+force configure to search for term.h in the given directory.
+
 On some systems a suitable development package with a name such as
 curses-devel or ncurses-devel needs to be installed before zsh can
 be compiled.  This is likely to be contained on any installation media,


-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: 4.3.4-dev-8

[Clint Adams]

On Tue, Jan 29, 2008 at 11:43:32AM +0000, Peter Stephenson wrote:
> ftp://ftp.zsh.org/pub/development/zsh-4.3.4-dev-8.tar.gz

Just a nit: the +x bits on some of these files seem unnecessary.
This is not unique to 4.3.4-dev-8.

-rwxr-xr-x pws/users      6059 2007-07-31 04:45 zsh-4.3.4-dev-8/Misc/globtests
-rwxr-xr-x pws/users      2975 2007-07-03 13:04 zsh-4.3.4-dev-8/Misc/globtests.ksh
-rwxr-xr-x pws/users      3858 2007-07-03 13:03 zsh-4.3.4-dev-8/Misc/c2z
-rwxr-xr-x pws/users     10350 2007-07-03 13:04 zsh-4.3.4-dev-8/Misc/lete2ctl
-rwxr-xr-x pws/users     44208 2006-11-14 07:11 zsh-4.3.4-dev-8/config.guess
-rwxr-xr-x pws/users      2276 2007-05-29 05:20 zsh-4.3.4-dev-8/Completion/Unix/Command/_chmod
-rwxr-xr-x pws/users      4862 2007-05-29 05:20 zsh-4.3.4-dev-8/Completion/Unix/Command/_cdrecord
-rwxr-xr-x pws/users      5958 2007-01-22 09:32 zsh-4.3.4-dev-8/Test/B03print.ztst
-rwxr-xr-x pws/users     13217 2008-01-04 07:59 zsh-4.3.4-dev-8/Test/ztst.zsh
-rwxr-xr-x pws/users     13184 2007-06-11 05:12 zsh-4.3.4-dev-8/install-sh
-rwxr-xr-x pws/users     32448 2006-11-14 07:11 zsh-4.3.4-dev-8/config.sub
-rwxr-xr-x pws/users      3495 2007-06-11 05:12 zsh-4.3.4-dev-8/mkinstalldirs
-rwxr-xr-x pws/users      1984 2000-05-06 04:05 zsh-4.3.4-dev-8/Util/mkdisttree.sh
-rwxr-xr-x pws/users      1701 2004-03-12 13:53 zsh-4.3.4-dev-8/Util/check_exports
-rwxr-xr-x pws/users      4209 2006-03-13 13:49 zsh-4.3.4-dev-8/Util/helpfiles
-rwxr-xr-x pws/users       279 2007-07-03 13:04 zsh-4.3.4-dev-8/Util/preconfig
-rwxr-xr-x pws/users      2721 2008-01-14 05:14 zsh-4.3.4-dev-8/Functions/Misc/run-help
-rwxr-xr-x pws/users        42 2007-12-31 17:13 zsh-4.3.4-dev-8/Functions/Misc/run-help-svk
-rwxr-xr-x pws/users      2062 2001-11-06 10:14 zsh-4.3.4-dev-8/Functions/Misc/mere
-rwxr-xr-x pws/users      6715 2007-12-14 06:58 zsh-4.3.4-dev-8/Functions/Misc/zcalc
-rwxr-xr-x pws/users      2154 2004-08-13 06:38 zsh-4.3.4-dev-8/Functions/Misc/zed
-rwxr-xr-x pws/users       155 2007-12-31 17:13 zsh-4.3.4-dev-8/Functions/Misc/run-help-git
-rwxr-xr-x pws/users        42 2007-12-31 17:13 zsh-4.3.4-dev-8/Functions/Misc/run-help-svn
-rwxr-xr-x pws/users        96 2007-07-26 04:55 zsh-4.3.4-dev-8/Functions/Misc/harden
-rwxr-xr-x pws/users       144 2006-03-13 14:01 zsh-4.3.4-dev-8/Functions/Zle/zed-set-file-name
-rwxr-xr-x pws/users      5736 2006-06-19 05:52 zsh-4.3.4-dev-8/Functions/Zle/url-quote-magic
-rwxr-xr-x pws/users    544223 2008-01-29 04:36 zsh-4.3.4-dev-8/configure
-rwxr-xr-x pws/users        58 1999-12-20 09:01 zsh-4.3.4-dev-8/.preconfig
-rwxr-xr-x pws/users      1445 2005-07-20 13:40 zsh-4.3.4-dev-8/Config/uninstallfns.sh
-rwxr-xr-x pws/users      1388 2007-07-26 04:56 zsh-4.3.4-dev-8/Config/installfns.sh
-rwxr-xr-x pws/users      1335 2003-06-20 06:46 zsh-4.3.4-dev-8/Etc/changelog2html.pl

Re: 4.3.4-dev-8

[Peter Stephenson]

Clint Adams wrote:
> On Tue, Jan 29, 2008 at 11:43:32AM +0000, Peter Stephenson wrote:
> > ftp://ftp.zsh.org/pub/development/zsh-4.3.4-dev-8.tar.gz
> 
> Just a nit: the +x bits on some of these files seem unnecessary.
> This is not unique to 4.3.4-dev-8.

That's a problem with CVS we can't easily fix, but I can post process.
For now it'll have to be by hand.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: 4.3.4-dev-8

[Ismail Dönmez]

At Tuesday 29 January 2008 around 13:43:32 Peter Stephenson wrote:
> I've uploaded 4.3.4-dev-8 to
>
> ftp://ftp.zsh.org/pub/development/zsh-4.3.4-dev-8.tar.gz
> ftp://ftp.zsh.org/pub/development/zsh-4.3.4-dev-8-doc.tar.gz
>
> If there are no new disasters I will release this as 4.3.5 in a couple
> of days.
>
> If you get a chance to look at the documentation let me know if there is
> anything obviously broken there.  I'm getting a warning about the
> texinfo node "User Configuration Functions" from pdftex which doesn't
> seem to make sense.

I see one warning from docs :

contrib.yo:2086: No macro: ssh(...)

Regards,
ismail

-- 
Never learn by your mistakes, if you do you may never dare to try again.

Re: 4.3.4-dev-8

[Wayne Davison]

On Tue, Jan 29, 2008 at 05:50:18PM +0000, Peter Stephenson wrote:
> That's a problem with CVS we can't easily fix, but I can post process.
> For now it'll have to be by hand.

You can reqeust such changes via SourceForge support request.  I took
care of that for you, and the files are no longer marked as executable.
(Except for "configure", which is a generated file -- I don't know
what's up with that.)

..wayne..

Re: 4.3.4-dev-8

[Vincent Lefevre]

On 2008-01-29 15:01:35 -0800, Wayne Davison wrote:
> On Tue, Jan 29, 2008 at 05:50:18PM +0000, Peter Stephenson wrote:
> > That's a problem with CVS we can't easily fix, but I can post process.
> > For now it'll have to be by hand.
> 
> You can reqeust such changes via SourceForge support request.  I took
> care of that for you, and the files are no longer marked as executable.
> (Except for "configure", which is a generated file -- I don't know
> what's up with that.)

Clint did *not* say *all* the files. AFAIK, the following files (from
the autotools) should be executable: config.guess, config.sub,
install-sh and mkinstalldirs. I don't know about the other ones.

-- 
Vincent Lefèvre <vincent@vinc17.org> - Web: <http://www.vinc17.org/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
Work: CR INRIA - computer arithmetic / Arenaire project (LIP, ENS-Lyon)

Re: 4.3.4-dev-8

[Peter Stephenson]

Ismail =?utf-8?q?D=C3=B6nmez?= wrote:
> I see one warning from docs :
> 
> contrib.yo:2086: No macro: ssh(...)

Thanks.

Index: Doc/Zsh/contrib.yo
===================================================================
RCS file: /cvsroot/zsh/zsh/Doc/Zsh/contrib.yo,v
retrieving revision 1.74
diff -u -r1.74 contrib.yo
--- Doc/Zsh/contrib.yo	29 Jan 2008 14:30:37 -0000	1.74
+++ Doc/Zsh/contrib.yo	30 Jan 2008 09:34:06 -0000
@@ -2055,7 +2055,7 @@
 
 An example assistant for the "ssh" command:
 
-example(run-help-ssh() {
+example(run-help-ssh+LPAR()RPAR() {
     emulate -LR zsh
     local -a args
     # Delete the "-l username" option


-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: 4.3.4-dev-8

[Peter Stephenson]

Vincent Lefevre wrote:
> On 2008-01-29 15:01:35 -0800, Wayne Davison wrote:
> > On Tue, Jan 29, 2008 at 05:50:18PM +0000, Peter Stephenson wrote:
> > > That's a problem with CVS we can't easily fix, but I can post process.
> > > For now it'll have to be by hand.
> > 
> > You can reqeust such changes via SourceForge support request.  I took
> > care of that for you, and the files are no longer marked as executable.
> > (Except for "configure", which is a generated file -- I don't know
> > what's up with that.)
> 
> Clint did *not* say *all* the files. AFAIK, the following files (from
> the autotools) should be executable: config.guess, config.sub,
> install-sh and mkinstalldirs. I don't know about the other ones.

Actually, there are quite a lot miscellaneous scripts that could
usefully be executable, and some of the functions are dual purpose.
There aren't many of that list that *definitely* shouldn't be
executable.

Configuration is now broken right from the word go:

% sh Util/preconfig
cd . && ./.preconfig
Util/preconfig: line 7: ./.preconfig: Permission denied
Util/preconfig: ./.preconfig failed (status 126)

I made and installed a shell from scratch and ".preconfig" was the
only thing that failed, although it's rather perverse not having the
scripts in Util and Misc executable.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: 4.3.4-dev-8

[Wayne Davison]

On Wed, Jan 30, 2008 at 09:54:48AM +0000, Peter Stephenson wrote:
> There aren't many of that list that *definitely* shouldn't be
> executable.

OK, they're all executable again.  If there are some you don't want
executable, let me know (or fill out a suppor request).

..wayne..

Re: 4.3.4-dev-8

[Clint Adams]

On Wed, Jan 30, 2008 at 09:54:48AM +0000, Peter Stephenson wrote:
> Actually, there are quite a lot miscellaneous scripts that could
> usefully be executable, and some of the functions are dual purpose.
> There aren't many of that list that *definitely* shouldn't be
> executable.

Well, my real problem is that these permissions propagate to the install
dir in the install target for reasons that I haven't looked into at all.

I suggest keeping these -x:

Completion/Unix/Command/_chmod
Completion/Unix/Command/_cdrecord
Test/B03print.ztst
Functions/Misc/run-help
Functions/Misc/run-help-svk
Functions/Misc/mere
Functions/Misc/zcalc
Functions/Misc/zed
Functions/Misc/run-help-git
Functions/Misc/run-help-svn
Functions/Misc/harden
Functions/Zle/zed-set-file-name
Functions/Zle/url-quote-magic

Re: 4.3.4-dev-8

[Peter Stephenson]

Clint Adams wrote:
> On Wed, Jan 30, 2008 at 09:54:48AM +0000, Peter Stephenson wrote:
> > Actually, there are quite a lot miscellaneous scripts that could
> > usefully be executable, and some of the functions are dual purpose.
> > There aren't many of that list that *definitely* shouldn't be
> > executable.
> 
> Well, my real problem is that these permissions propagate to the install
> dir in the install target for reasons that I haven't looked into at all.
> 
> I suggest keeping these -x:
> 
> Completion/Unix/Command/_chmod
> Completion/Unix/Command/_cdrecord
> Test/B03print.ztst
> Functions/Misc/run-help
> Functions/Misc/run-help-svk
> Functions/Misc/mere
> Functions/Misc/zcalc
> Functions/Misc/zed
> Functions/Misc/run-help-git
> Functions/Misc/run-help-svn
> Functions/Misc/harden
> Functions/Zle/zed-set-file-name
> Functions/Zle/url-quote-magic

That seems reasonable---the first three certainly.  The functions are
arguable since some of them can be scripts, but given they are installed
into the function directory it does make sense for them to be treated
just as plain files.


-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: 4.3.4-dev-8

[Clint Adams]

On Thu, Jan 31, 2008 at 10:01:24AM +0000, Peter Stephenson wrote:
> That seems reasonable---the first three certainly.  The functions are
> arguable since some of them can be scripts, but given they are installed
> into the function directory it does make sense for them to be treated
> just as plain files.

Now request ID 1883589. I hope I've done this correctly; I couldn't find
Wayne's previous requests to use as templates.

Re: 4.3.4-dev-8

[Peter Stephenson]

On Thu, 31 Jan 2008 11:17:09 -0500
Clint Adams <clint@zsh.org> wrote:
> On Thu, Jan 31, 2008 at 10:01:24AM +0000, Peter Stephenson wrote:
> > That seems reasonable---the first three certainly.  The functions are
> > arguable since some of them can be scripts, but given they are installed
> > into the function directory it does make sense for them to be treated
> > just as plain files.
> 
> Now request ID 1883589. I hope I've done this correctly; I couldn't find
> Wayne's previous requests to use as templates.

Just done a check out and it definitely looks better.  I see there's some
completion functions we missed, but apart from that nothing stands out.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070