zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Cc: 749969-forwarded@bugs.debian.org
Subject: Re: Bug#749969: history no longer syncs immediately, INC_APPEND_HISTORY broken
Date: Sat, 31 May 2014 20:22:11 +0100	[thread overview]
Message-ID: <20140531202211.396cd06e@pws-pc.ntlworld.com> (raw)
In-Reply-To: <87d2eu5mmg.fsf@ft.bewatermyfriend.org>

On Sat, 31 May 2014 11:21:59 +0200
Frank Terbeck <ft@bewatermyfriend.org> wrote:
> I think to enable both ways to be possible, there should be two options:
> INC_APPEND_HISTORY that enables the original behaviour and (if the name
> is agreeable) DELAY_INC_APPEND_HISTORY, that amends the behaviour of the
> original option in the way that is reflected by the current behaviour.

The issue is that, without rewriting the history, either the time taken
for the command is wrong (that was the old case) or the command isn't
written out to the history until it's finished (that's the current
position).  Writing the history to get the best of both worlds probably
isn't beyond the bounds of 21st century science, but it's beyond my
understanding of the history code at the moment.  So at the moment
having two options looks like the only way to allow you to achieve any
one of the effects.  I think the new behaviour could be
INC_APPEND_HISTORY_TIME which puts it next to the original one and
indicates why it exists.

I haven't looked, but I don't think this ought to be too difficult ---
there are still some reasons why you might have to deal with history at
the original place anyway, so it should be possible to add an option
test at that point as well as one at the later point.

pws


  reply	other threads:[~2014-05-31 19:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140531074936.GA9011@valiant.palfrader.org>
2014-05-31  9:21 ` Frank Terbeck
2014-05-31 19:22   ` Peter Stephenson [this message]
2014-06-03 19:56     ` Peter Stephenson
2014-06-04  7:57       ` Han Pingtian
2014-06-04 14:50         ` Bart Schaefer
2014-06-04 16:13       ` Bart Schaefer
2014-06-01  6:05   ` Wayne Davison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140531202211.396cd06e@pws-pc.ntlworld.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=749969-forwarded@bugs.debian.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).