From: Frank Terbeck <ft@bewatermyfriend.org>
To: zsh-workers@zsh.org
Cc: 749969-forwarded@bugs.debian.org,
Peter Palfrader <weasel@debian.org>,
Han Pingtian <hanpt@linux.vnet.ibm.com>
Subject: Re: Bug#749969: history no longer syncs immediately, INC_APPEND_HISTORY broken
Date: Sat, 31 May 2014 11:21:59 +0200 [thread overview]
Message-ID: <87d2eu5mmg.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <20140531074936.GA9011@valiant.palfrader.org> (Peter Palfrader's message of "Sat, 31 May 2014 09:49:39 +0200")
Hi list,
Debian's BTS received a regression report for zsh.
I'll include a slightly shortened account of the bug-reporter's
findings. The version in "stable" he references is 4.3.17; the version
that shows the broken behaviour is 5.0.5 (and I suspect that releases
starting at 5.0.3 will contain the regression):
Peter Palfrader wrote:
[...]
> since upgrading from stable, I noticed that zsh no longer adds commands
> to the history immediately when they are started. They only get added
> when they have finished.
>
> That's a regression from stable, where things got added as soon as they
> started.
>
> This is as important feature for me, as I often want to run similar
> (long running) commands at the same time. I.e., I issue a command, open
> a new shell in a new terminal emulator window, slightly modify it and
> send it off. Now that's no longer possible.
>
> E.g.:
> - Run "sleep 10" in a zsh in your favorite terminal emulator.
> - Open a second window. "sleep 10" is not yet in your history.
> - <wait 10 seconds>
> - Open a third window. "sleep 10" is now there.
>
> Ideally the sleep 10 would be there even in the second window.
[...]
> All I ask is that INC_APPEND_HISTORY again work as documented:
>
> | This options works like APPEND_HISTORY except that new history
> | lines are added to the $HISTFILE incrementally (as soon as they
> ^^^^^^^^^^^^^^^^
> | are entered)
> ^^^^^^^^^^^^
I've skimmed through our version control history, and I'm pretty sure
the reason for this is 16ff79a885f aka workers-31789 aka ¹. And I agree
that it's a regression, that breaks long standing behaviour, which
affects at least the use case that Peter describes.
I think to enable both ways to be possible, there should be two options:
INC_APPEND_HISTORY that enables the original behaviour and (if the name
is agreeable) DELAY_INC_APPEND_HISTORY, that amends the behaviour of the
original option in the way that is reflected by the current behaviour.
If your first instinct is to suggest enabling SHARE_HISTORY, then please
note, that that's a rather intrusive option that can't possibly be
forced onto users that don't want it (I wouldn't want it, and the bug
reporter doesn't either).
CC:ing Han, who is the original author. PWS, who did some refinements on
top of Han's original code, reads all mails on -workers anyway. ;)
Regards, Frank
¹ http://www.zsh.org/mla/workers/2013/msg00824.html
--
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
-- RFC 1925
next parent reply other threads:[~2014-05-31 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140531074936.GA9011@valiant.palfrader.org>
2014-05-31 9:21 ` Frank Terbeck [this message]
2014-05-31 19:22 ` Peter Stephenson
2014-06-03 19:56 ` Peter Stephenson
2014-06-04 7:57 ` Han Pingtian
2014-06-04 14:50 ` Bart Schaefer
2014-06-04 16:13 ` Bart Schaefer
2014-06-01 6:05 ` Wayne Davison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2eu5mmg.fsf@ft.bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=749969-forwarded@bugs.debian.org \
--cc=hanpt@linux.vnet.ibm.com \
--cc=weasel@debian.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).