Re: Bug#749969: history no longer syncs immediately, INC_APPEND_HISTORY broken

[Bart Schaefer <schaefer@brasslantern.com>]

On Jun 3,  8:56pm, Peter Stephenson wrote:
}
} I think this works, but it's getting pretty silly.

There are a number of cases where binary on/off options don't really lend
themselves to describing complex behavior.

 
} +     * For INCAPPENDHISTORYTIME, when interactive, save the history here
}       * as it gives a better estimate of the times of commands.
}       *
} +     * If INCAPPENDHISTORY is also set we've already done it.

I was somewhat concerned that this implies that given

    % setopt INCAPPENDHISTORY INCAPPENDHISTORYTIME
    % unsetopt INCAPPENDHISTORY

the unsetopt command would be appended to the history more than once,
but some other part of the tests apparently prevents that.

The doc for INC_APPEND_HISTORY_TIME should probably point out that the
option has no effect when INC_APPEND_HISTORY or SHARE_HISTORY is set,
and the "you want more control" paragraph under SHARE_HISTORY might
suggest INC_APPEND_HISTORY_TIME instead of INC_APPEND_HISTORY.