History bug in zsh 5.0.5

History bug in zsh 5.0.5

[RoboSloNE]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]


Hello,

I found this bug in latest zsh (I’ve not tried git version yet): incremental history doesn’t work right after command is executed, it waits for the next command to log first one.

> How to reproduce:
> 1. Enable this options in ~/.zshrc: extended_history, inc_append_history, share_history
> 2. Restart shell
> 3. Open two tabs (shells)
> 4. Type 'echo 123' in first shell
> 5. Press Ctrl+R in second shell: 'echo 123' is not in history
> 6. Just press enter
> 7. CTRL+R, and you'll see the updated list

Maybe this discussion will be some help.
Thanks in advance.

Re: History bug in zsh 5.0.5

[Bart Schaefer]

This has already been reported and a patch can be found in the article
zsh-workers/32682 ( http://www.zsh.org/mla/workers/2014/msg00470.html )

It was an intentional change to fix a different problem (elapsed time
accuracy) but we underestimated the importance for some users of having
the immediate file update.

Re: History bug in zsh 5.0.5

[Axel Beckert]

Hi Bart,

On Wed, Jun 04, 2014 at 11:36:47AM +0400, RoboSloNE wrote:
> I found this bug in latest zsh (I’ve not tried git version yet):
> incremental history doesn’t work right after command is executed, it
> waits for the next command to log first one.
> 
> > How to reproduce:
> > 1. Enable this options in ~/.zshrc: extended_history, inc_append_history, share_history
> > 2. Restart shell
> > 3. Open two tabs (shells)
> > 4. Type 'echo 123' in first shell
> > 5. Press Ctrl+R in second shell: 'echo 123' is not in history
> > 6. Just press enter
> > 7. CTRL+R, and you'll see the updated list

On Wed, Jun 04, 2014 at 07:55:59AM -0700, Bart Schaefer wrote:
> This has already been reported and a patch can be found in the article
> zsh-workers/32682 ( http://www.zsh.org/mla/workers/2014/msg00470.html )
> 
> It was an intentional change to fix a different problem (elapsed time
> accuracy) but we underestimated the importance for some users of having
> the immediate file update.

Are you sure these are the same things? I'm not.

But I thought so first, too. :-) There's no sleep or such in
RoboSloNE's report and it's about SHARE_HISTORY which
zsh-workers/32682 isn't (IIRC).

I think he rather argues, that Ctrl-R should already reread the
history from disk and not only the next command (or an empty command
by just pressing enter).

		Kind regards, Axel
-- 
/~\  Plain Text Ribbon Campaign                   | Axel Beckert
\ /  Say No to HTML in E-Mail and News            | abe@deuxchevaux.org  (Mail)
 X   See http://www.nonhtmlmail.org/campaign.html | abe@noone.org (Mail+Jabber)
/ \  I love long mails: http://email.is-not-s.ms/ | http://noone.org/abe/ (Web)

Re: History bug in zsh 5.0.5

[Peter Stephenson]

On Wed, 04 Jun 2014 17:09:42 +0200
Axel Beckert <abe@deuxchevaux.org> wrote:
> But I thought so first, too. :-) There's no sleep or such in
> RoboSloNE's report and it's about SHARE_HISTORY which
> zsh-workers/32682 isn't (IIRC).

However, INC_APPEND_HISTORY is set, according to the report .  It
shouldn't be if the behaviour you want is the (pure) SHARE_HISTORY one.
So it probably is the same issue.

pws

Re: History bug in zsh 5.0.5

[Bart Schaefer]

On Jun 4,  5:09pm, Axel Beckert wrote:
}
} > > How to reproduce:
} > > 1. Enable this options in ~/.zshrc: extended_history, inc_append_history, share_history
} > > 2. Restart shell
} > > 3. Open two tabs (shells)
} > > 4. Type 'echo 123' in first shell
} > > 5. Press Ctrl+R in second shell: 'echo 123' is not in history
} > > 6. Just press enter
} > > 7. CTRL+R, and you'll see the updated list
} 
} There's no sleep or such in
} RoboSloNE's report and it's about SHARE_HISTORY which
} zsh-workers/32682 isn't (IIRC).
} 
} I think he rather argues, that Ctrl-R should already reread the
} history from disk and not only the next command (or an empty command
} by just pressing enter).

Hm, I see your point, it's not clear which shell is step (6).

If he thinks ^R ought to be reading the shared history before it starts
a search, though, he's reporting a "bug" that has existed for as long
as there has been shared history, because the file has never been re-
read except between redraws of the prompt.