From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: zsh 5.0.5-dev-2
Date: Thu, 14 Aug 2014 10:32:27 +0100 [thread overview]
Message-ID: <20140814103227.74c7d168@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <20140814093442.1a74c5b7@pwslap01u.europe.root.pri>
On Thu, 14 Aug 2014 09:34:42 +0100
Peter Stephenson <p.stephenson@samsung.com> wrote:
> On Thu, 14 Aug 2014 00:34:54 +0200
> Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> > The bug reported in 32431 and 32550 is still there.
> >
> > Can we perhaps just remove or comment out that one error message for a
> > release?
>
> zsh -fw
> cd /
> zsh: path expansion failed, using root directory
>
> We certainly need to do something. But if this is the only issue, can't
> it be straightforwardly fixed like this?
If someone can reassure me that the weird undocumented interaction with
xbuf bypassing parameter passing starts here --- i.e. we are resetting
xbuf here, then xsymlinks fiddles with it and this code looks at the
result --- then I can't see how this change can be wrong as far as it
goes. The question is, is there more to it?
> diff --git a/Src/utils.c b/Src/utils.c
> index 998e46a..75fadd5 100644
> --- a/Src/utils.c
> +++ b/Src/utils.c
> @@ -780,6 +780,8 @@ xsymlink(char *s)
> {
> if (*s != '/')
> return NULL;
> + if (!s[1])
> + return ztrdup("/");
> *xbuf = '\0';
> xsymlinks(s + 1);
> if (!*xbuf) {
pws
next prev parent reply other threads:[~2014-08-14 9:32 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 20:29 Peter Stephenson
2014-08-12 22:36 ` Axel Beckert
2014-08-13 14:04 ` zsh 5.0.5-dev-2 / Occassional hangs on Test/A05execution.ztst Axel Beckert
2014-08-13 19:08 ` Bart Schaefer
2014-08-14 8:48 ` Axel Beckert
2014-08-14 8:50 ` Peter Stephenson
2014-08-14 16:25 ` Bart Schaefer
2014-08-14 16:31 ` Axel Beckert
2014-08-14 17:34 ` Axel Beckert
2014-08-15 4:50 ` Bart Schaefer
2014-08-15 9:32 ` Axel Beckert
2014-08-15 17:33 ` Bart Schaefer
2014-08-15 19:42 ` Axel Beckert
2014-08-16 18:12 ` zsh 5.0.5/6 Peter Stephenson
2014-08-13 17:28 ` zsh 5.0.5-dev-2 Dominic Hopf
2014-08-13 22:34 ` Oliver Kiddle
2014-08-14 8:34 ` Peter Stephenson
2014-08-14 9:32 ` Peter Stephenson [this message]
2014-08-14 16:20 ` Bart Schaefer
2014-08-14 19:54 ` Peter Stephenson
2014-08-15 4:44 ` Bart Schaefer
2014-08-15 8:38 ` Peter Stephenson
2014-08-15 11:23 ` Han Pingtian
2014-08-15 17:17 ` Bart Schaefer
2014-08-16 0:35 ` Han Pingtian
2014-08-17 17:30 ` Bart Schaefer
2014-08-18 2:56 ` Han Pingtian
2014-08-18 6:36 ` Bart Schaefer
2014-08-18 14:02 ` Han Pingtian
2014-08-23 17:51 ` Symlink chasing Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140814103227.74c7d168@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).