zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: zsh 5.0.5-dev-2
Date: Fri, 15 Aug 2014 09:38:01 +0100	[thread overview]
Message-ID: <20140815093801.501a465d@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <140814214412.ZM4177@torch.brasslantern.com>

On Thu, 14 Aug 2014 21:44:12 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> Maybe just make xsymlinks() have a ternary return value instead of a
> boolean one, and return an actual error value in the case where we've
> truncated on overflow instead of as part of normal expansion to root?

Sounds reasonable for now.  Thanks.

> I don't know if all of these changes are necessary.  It has always
> bothered me that the return value of the recursive calls to xsymlinks()
> are ignored, but maybe this isn't the right way to handle them.

Yes, the way the calls a nested is a bit of a mess.

> Incidentally, anybody recall what the obviously obsolete comment above
> the xsymlinks() definition in Src/utils.c is about?

No, I noticed that but don't remember the history.

pws


  reply	other threads:[~2014-08-15  8:38 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-12 20:29 Peter Stephenson
2014-08-12 22:36 ` Axel Beckert
2014-08-13 14:04   ` zsh 5.0.5-dev-2 / Occassional hangs on Test/A05execution.ztst Axel Beckert
2014-08-13 19:08     ` Bart Schaefer
2014-08-14  8:48       ` Axel Beckert
2014-08-14  8:50       ` Peter Stephenson
2014-08-14 16:25         ` Bart Schaefer
2014-08-14 16:31           ` Axel Beckert
2014-08-14 17:34             ` Axel Beckert
2014-08-15  4:50               ` Bart Schaefer
2014-08-15  9:32                 ` Axel Beckert
2014-08-15 17:33                   ` Bart Schaefer
2014-08-15 19:42                     ` Axel Beckert
2014-08-16 18:12                       ` zsh 5.0.5/6 Peter Stephenson
2014-08-13 17:28   ` zsh 5.0.5-dev-2 Dominic Hopf
2014-08-13 22:34 ` Oliver Kiddle
2014-08-14  8:34   ` Peter Stephenson
2014-08-14  9:32     ` Peter Stephenson
2014-08-14 16:20       ` Bart Schaefer
2014-08-14 19:54         ` Peter Stephenson
2014-08-15  4:44           ` Bart Schaefer
2014-08-15  8:38             ` Peter Stephenson [this message]
2014-08-15 11:23             ` Han Pingtian
2014-08-15 17:17               ` Bart Schaefer
2014-08-16  0:35                 ` Han Pingtian
2014-08-17 17:30                   ` Bart Schaefer
2014-08-18  2:56                     ` Han Pingtian
2014-08-18  6:36                       ` Bart Schaefer
2014-08-18 14:02                         ` Han Pingtian
2014-08-23 17:51                     ` Symlink chasing Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140815093801.501a465d@pwslap01u.europe.root.pri \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).