From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Mateusz Karbowy <mateusz.karbowy@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: PATCH: 3.0.8: git completion update for cherry-pick
Date: Thu, 27 Aug 2015 23:11:52 +0000 [thread overview]
Message-ID: <20150827231152.GD21994@tarsus.local2> (raw)
In-Reply-To: <CAFiR=JvJefLthQnoQ2YY-nQF69jgAXo76dzMit7sBRBZVgiq_Q@mail.gmail.com>
Mateusz Karbowy wrote on Tue, Aug 25, 2015 at 23:26:21 +0100:
> My last patch interfered with git-checkout. I've fixed it this time.
>
Sorry for the late reply.
I have only two comments about this patch: one bugfix and one question.
> @@ -511,7 +513,7 @@ _git-cherry-pick () {
> '*'{-s,--strategy=}'[use given merge strategy]:merge strategy:__git_merge_strategies' \
> '*'{-X,--strategy-option=}'[pass merge-strategy-specific option to merge strategy]' \
> '(-e --edit -x -n --no-commit -s --signoff)--ff[fast forward, if possible]' \
> - ': :__git_commit_ranges'
> + ': : __git_commit_ranges -O expl -C git_commit_opts'
There are other callers of __git_commit_ranges that pass compadd options in
argv. There is already a compadd option "-C", therefore, choosing this option
letter prevents any caller of __git_commit_ranges from passing the compadd -C
option.
Is this a problem? Should we find some other way to pass the name
"git_commit_opts"? If so, what option letters are available? (Since "-O" is
available, maybe we could pass both array names in it as '-O
"expl:git_commit_opts"'? I.e., if a colon is present in the argument
value, split on it, else assume the entire argument is a single
parameter name, as in the conventional "-O expl"?)
> __git_commits () {
> ...
> + expl=( $@ )
The $@ should be double-quoted to avoid eliding empty arguments.
>
Apart from these two issues, the patch seems ready for commit to me.
Thanks again.
Cheers,
Daniel
next prev parent reply other threads:[~2015-08-27 23:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 22:19 Mateusz Karbowy
2015-07-22 11:53 ` Daniel Shahaf
2015-08-10 21:31 ` Mateusz Karbowy
2015-08-11 22:06 ` Daniel Shahaf
2015-08-19 17:10 ` Mateusz Karbowy
2015-08-21 19:55 ` Mateusz Karbowy
2015-08-23 6:42 ` Daniel Shahaf
2015-08-25 22:26 ` Mateusz Karbowy
2015-08-27 23:11 ` Daniel Shahaf [this message]
2015-08-27 23:19 ` Bart Schaefer
2015-08-27 23:28 ` Daniel Shahaf
2015-08-29 16:53 ` Mateusz Karbowy
2015-08-30 22:39 ` Daniel Shahaf
2015-08-31 7:50 ` Mateusz Karbowy
2015-09-01 4:19 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150827231152.GD21994@tarsus.local2 \
--to=d.s@daniel.shahaf.name \
--cc=mateusz.karbowy@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).