From: Mateusz Karbowy <mateusz.karbowy@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Subject: Re: PATCH: 3.0.8: git completion update for cherry-pick
Date: Mon, 31 Aug 2015 08:50:02 +0100 [thread overview]
Message-ID: <CAFiR=JuWVbqPFMiRVDcfkejKFfbnKVQzzBTqBecmspijRFA9yw@mail.gmail.com> (raw)
In-Reply-To: <20150830223945.GC12415@tarsus.local2>
Thanks Daniel! :)
On 30 August 2015 at 23:39, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Mateusz Karbowy wrote on Sat, Aug 29, 2015 at 17:53:57 +0100:
>> I've fixed the no-quotes issue with $@ and now I'm passing both
>> compadd and git commit options using one -O parameter (the array names
>> are separated with colon, as you suggested).
>
> Looks good.
>
> I've made a few changes (see attached series):
>
> 1. Some style tweaks
>
> 2. Avoid printing wrong [HEAD~$n] descriptions in __git_recent_commits
>
> 3. Extra safety check in case somebody passed just the traditional '-O
> expl' with no colon
>
> I'll commit the patch with those changes (as soon as I get an X-Seq
> number for this email). Many thanks!
>
> Daniel
>
next prev parent reply other threads:[~2015-08-31 7:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-18 22:19 Mateusz Karbowy
2015-07-22 11:53 ` Daniel Shahaf
2015-08-10 21:31 ` Mateusz Karbowy
2015-08-11 22:06 ` Daniel Shahaf
2015-08-19 17:10 ` Mateusz Karbowy
2015-08-21 19:55 ` Mateusz Karbowy
2015-08-23 6:42 ` Daniel Shahaf
2015-08-25 22:26 ` Mateusz Karbowy
2015-08-27 23:11 ` Daniel Shahaf
2015-08-27 23:19 ` Bart Schaefer
2015-08-27 23:28 ` Daniel Shahaf
2015-08-29 16:53 ` Mateusz Karbowy
2015-08-30 22:39 ` Daniel Shahaf
2015-08-31 7:50 ` Mateusz Karbowy [this message]
2015-09-01 4:19 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFiR=JuWVbqPFMiRVDcfkejKFfbnKVQzzBTqBecmspijRFA9yw@mail.gmail.com' \
--to=mateusz.karbowy@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).