zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: m0viefreak <m0viefreak.cm@googlemail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] isearch: do not use PAT_STATIC since we call zle hooks
Date: Mon, 9 Jan 2017 01:35:26 +0000	[thread overview]
Message-ID: <20170109013526.GA25236@fujitsu.shahaf.local2> (raw)
In-Reply-To: <20170106172541.GA14113@fujitsu.shahaf.local2>

m0viefreak wrote on Fri, Jan 06, 2017 at 17:25:41 +0000:
> Minimal reproducing example:
> 
> % bindkey '^R' history-incremental-pattern-search-backward
> % evil_hook() { a=(); : ${a[(r)foo*]}; };
> % zle -N zle-isearch-update evil_hook
> % : foo
> % : bar
> % : baz
> %
> 
> type: <^R>b
> % : baz
> bck-i-search: b_
> 
> type: <^R>
> % : foo
> bck-i-search: b_
> 
> ': foo' is found instead of ': bar' because evil_hook modified the
> static pattern used in isearch.
> 
> Related: zsh-syntax-highlighting issue which found this bug:
> https://github.com/zsh-users/zsh-syntax-highlighting/issues/407

Is there a way to probe for this bug at runtime?  I.e., a way for
a script to determine whether the zsh binary that interprets it has or
hasn't this bug?

We need this in z-sy-h to choose between two codepaths (and we'd
rather not use is-at-least in case distros backport m0vie's patch).

Thanks,

Daniel


  parent reply	other threads:[~2017-01-09  1:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 17:25 m0viefreak
2017-01-06 17:35 ` Bart Schaefer
2017-01-08 19:33 ` Bart Schaefer
2017-01-08 19:40   ` Peter Stephenson
2017-01-28 19:02     ` Bart Schaefer
2017-01-28 19:15       ` Peter Stephenson
2017-01-28 19:39       ` Bart Schaefer
2017-01-28 19:47         ` Peter Stephenson
2017-01-29  0:01           ` Bart Schaefer
2017-01-29 16:24             ` Bart Schaefer
2017-01-09  1:35 ` Daniel Shahaf [this message]
2017-01-09  1:48   ` Bart Schaefer
2017-01-11  2:01     ` Fwd: " Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170109013526.GA25236@fujitsu.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=m0viefreak.cm@googlemail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).