zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: m0viefreak <m0viefreak.cm@googlemail.com>, zsh-workers@zsh.org
Subject: Re: [PATCH] isearch: do not use PAT_STATIC since we call zle hooks
Date: Fri, 6 Jan 2017 09:35:06 -0800	[thread overview]
Message-ID: <170106093506.ZM7618@torch.brasslantern.com> (raw)
In-Reply-To: <20170106172541.GA14113@fujitsu.shahaf.local2>

On Jan 6,  5:25pm, m0viefreak wrote:
}
} Using PAT_STATIC, any of the functions called in the hook that make
} use of patterns, implicitly change the pattern we use in the
} isearch loop. In the best case this results in pattern-not-found,
} in the worst case we get a dump.

Thanks for catching this.  I expect we're going to be findind this
kind of thing elsewhere, now that we have so many hook points -- lots
of code that was written expecting it would never be re-entered is
potentially going to be invoked from hooks, possibly even from hooks
within hooks.


  reply	other threads:[~2017-01-08  1:14 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 17:25 m0viefreak
2017-01-06 17:35 ` Bart Schaefer [this message]
2017-01-08 19:33 ` Bart Schaefer
2017-01-08 19:40   ` Peter Stephenson
2017-01-28 19:02     ` Bart Schaefer
2017-01-28 19:15       ` Peter Stephenson
2017-01-28 19:39       ` Bart Schaefer
2017-01-28 19:47         ` Peter Stephenson
2017-01-29  0:01           ` Bart Schaefer
2017-01-29 16:24             ` Bart Schaefer
2017-01-09  1:35 ` Daniel Shahaf
2017-01-09  1:48   ` Bart Schaefer
2017-01-11  2:01     ` Fwd: " Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170106093506.ZM7618@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=m0viefreak.cm@googlemail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).