From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] isearch: do not use PAT_STATIC since we call zle hooks
Date: Sat, 28 Jan 2017 19:47:17 +0000 [thread overview]
Message-ID: <20170128194717.00b4be7e@ntlworld.com> (raw)
In-Reply-To: <alpine.LRH.2.00.1701281129510.4560@toltec.zanshin.com>
On Sat, 28 Jan 2017 11:39:02 -0800 (PST)
Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Sat, 28 Jan 2017, Bart Schaefer wrote:
>
> > ... back to deciding whether each individual use of PAT_STATIC is safe
> > WRT signals and hooks.
>
> Crimony, it looks like pretty much all of compctl.c is signal-UNsafe.
>
> All the functions are static[*] except for the zmodload entry points.
> Would it be asking for trouble to wrap all the builtin and widget
> implementations of compctl in queue_signals()/unqueue_signals()?
Well, I think the definitive answer is probably the usual "who knows
what anyone's doing with zsh features?"
But my gut feel is compctl only ever got to the point that it was doing
simple local stuff that finished quickly, and we're morally entitled to
assume that anything that isn't like that is using compsys. So I'd be
inclined to try what you suggest and just make sure a few simple builtin
completions with compctl work.
pws
next prev parent reply other threads:[~2017-01-28 19:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-06 17:25 m0viefreak
2017-01-06 17:35 ` Bart Schaefer
2017-01-08 19:33 ` Bart Schaefer
2017-01-08 19:40 ` Peter Stephenson
2017-01-28 19:02 ` Bart Schaefer
2017-01-28 19:15 ` Peter Stephenson
2017-01-28 19:39 ` Bart Schaefer
2017-01-28 19:47 ` Peter Stephenson [this message]
2017-01-29 0:01 ` Bart Schaefer
2017-01-29 16:24 ` Bart Schaefer
2017-01-09 1:35 ` Daniel Shahaf
2017-01-09 1:48 ` Bart Schaefer
2017-01-11 2:01 ` Fwd: " Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170128194717.00b4be7e@ntlworld.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).