From: Peter Stephenson <p.stephenson@samsung.com>
To: zsh-workers@zsh.org
Subject: Re: [BUG] Anonymous functions cause funcfiletrace to produce function-relative line numbers
Date: Mon, 11 Dec 2017 09:41:16 +0000 [thread overview]
Message-ID: <20171211094116.48e29012@pwslap01u.europe.root.pri> (raw)
In-Reply-To: <E7CE1AD5-1169-46C2-9776-1C9B9BDEEB9B@dana.is>
On Sun, 10 Dec 2017 17:28:03 -0600
dana <dana@dana.is> wrote:
> I was experimenting with line-number tracing today and i found that anonymous
> functions have an undesirable effect on funcfiletrace:
>
> % cat -n tracetest.zsh
> 1 #
> 2 foo() {
> 3 #
> 4 #
> 5 #
> 6 #
> 7 #
> 8 () { () { print -rC2 -- $functrace $funcfiletrace } }
> 9 }
> 10 foo
> % zsh tracetest.zsh
> (anon):0 tracetest.zsh:6
> foo:6 tracetest.zsh:8
> tracetest.zsh:10 tracetest.zsh:10
>
> Note that the top call from (anon) is listed as tracetest.zsh:6 (actually the
> relative line number within the function foo) rather than the expected
> tracetest.zsh:8 (the absolute line number within the file).
I don't think this is just anonymous functions; I think the problem is
the temptation to use nested functions is just greater with anonymous
functions.
Perhaps...?
pws
diff --git a/Src/exec.c b/Src/exec.c
index fc6d02d..03b7f3d 100644
--- a/Src/exec.c
+++ b/Src/exec.c
@@ -5669,11 +5669,11 @@ doshfunc(Shfunc shfunc, LinkList doshargs, int noreturnval)
funcsave->fstack.caller = funcstack ? funcstack->name :
dupstring(funcsave->argv0 ? funcsave->argv0 : argzero);
funcsave->fstack.lineno = lineno;
+ funcsave->fstack.flineno = funcstack->flineno + shfunc->lineno;
funcsave->fstack.prev = funcstack;
funcsave->fstack.tp = FS_FUNC;
funcstack = &funcsave->fstack;
- funcsave->fstack.flineno = shfunc->lineno;
funcsave->fstack.filename = getshfuncfile(shfunc);
prog = shfunc->funcdef;
next prev parent reply other threads:[~2017-12-11 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171210232854epcas2p2f9d4f0ac2ad31feb5a54d61da49e7140@epcas2p2.samsung.com>
2017-12-10 23:28 ` dana
2017-12-11 9:41 ` Peter Stephenson [this message]
2017-12-11 10:12 ` Peter Stephenson
2017-12-11 21:57 ` dana
2017-12-15 10:21 ` Peter Stephenson
2017-12-15 18:45 ` dana
2017-12-16 21:10 ` Bart Schaefer
2017-12-16 22:33 ` dana
2017-12-18 9:01 ` Peter Stephenson
2017-12-20 17:39 ` Peter Stephenson
2017-12-20 22:26 ` dana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171211094116.48e29012@pwslap01u.europe.root.pri \
--to=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).