zsh-workers
 help / color / mirror / code / Atom feed
From: dana <dana@dana.is>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: zsh-workers@zsh.org
Subject: Re: [BUG] Anonymous functions cause funcfiletrace to produce function-relative line numbers
Date: Mon, 11 Dec 2017 15:57:06 -0600	[thread overview]
Message-ID: <26AB704C-51B8-49FE-87E2-3BCDE5F7DF42@dana.is> (raw)
In-Reply-To: <20171211101238.410a91b1@pwslap01u.europe.root.pri>

On 11 Dec 2017, at 04:12, Peter Stephenson <p.stephenson@samsung.com> wrote:
> Oops, try this instead.

This one does not seem to have been entirely successful.

The reason i encountered this is that i was playing with a 'panic' function that
prints a trace-back. Here's a test script that replicates the basic 'stack' i
had going before:

  panic() {
    print -rC2 -- $functrace $funcfiletrace
    exit 1
  }
  puts() {
    panic
  }
  main() {
    () { puts }
  }
  main

The output, after applying the patch:

  puts:1            tracetest.zsh:15
  (anon):0          tracetest.zsh:9
  main:1            tracetest.zsh:9
  tracetest.zsh:11  tracetest.zsh:11

The line number for the (anon) call is correct now, but the one for the puts
call is wrong — there aren't even 15 lines in the script.

With my real-world code that line number seemed to be the sum of the current
function-relative number and the previous file-absolute number. That isn't the
case in this example, but maybe it had something to do with the fact that my
functions were all in separate files, unlike the ones here. Or it could be a
coincidence i guess.

dana


  reply	other threads:[~2017-12-11 21:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20171210232854epcas2p2f9d4f0ac2ad31feb5a54d61da49e7140@epcas2p2.samsung.com>
2017-12-10 23:28 ` dana
2017-12-11  9:41   ` Peter Stephenson
2017-12-11 10:12     ` Peter Stephenson
2017-12-11 21:57       ` dana [this message]
2017-12-15 10:21         ` Peter Stephenson
2017-12-15 18:45           ` dana
2017-12-16 21:10             ` Bart Schaefer
2017-12-16 22:33               ` dana
2017-12-18  9:01             ` Peter Stephenson
2017-12-20 17:39               ` Peter Stephenson
2017-12-20 22:26                 ` dana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26AB704C-51B8-49FE-87E2-3BCDE5F7DF42@dana.is \
    --to=dana@dana.is \
    --cc=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).