zsh-workers
 help / color / mirror / code / Atom feed
From: dana <dana@dana.is>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: zsh-workers@zsh.org
Subject: Re: [BUG] Anonymous functions cause funcfiletrace to produce function-relative line numbers
Date: Fri, 15 Dec 2017 12:45:47 -0600	[thread overview]
Message-ID: <FDA58405-4654-4DFC-951F-7E467CF836B2@dana.is> (raw)
In-Reply-To: <20171215102118.7bdfff2e@pwslap01u.europe.root.pri>

On 15 Dec 2017, at 04:21, Peter Stephenson <p.stephenson@samsung.com> wrote:
>See if this helps...

Thanks. After applying the new patch, the line numbers all look good with the
test case i provided, whether it's executed from a file or from stdin. I also
tried it with the functions in separate files, and they look correct there
too... unless you use ksh-style definitions.

Test case for that:

  % < panic
  panic() {
    print -rC2 -- $functrace $funcfiletrace
    exit 1
  }

  % < puts
  #
  puts() {
    #
    #
    panic
  }

  % < tracetest.zsh
  fpath=( . )
  autoload -Uz panic puts
  main() {
    () { puts }
  }
  main

  % ZDOTDIR=. Src/zsh tracetest.zsh
  puts:3           /Users/dana/.../zsh/puts:3
  (anon):0         tracetest.zsh:4
  main:1           tracetest.zsh:4
  tracetest.zsh:6  tracetest.zsh:6

The file line number at the top should be 5.

I tried a few 'real-world' cases and they matched the above — looks fine without
the ksh-style definition, but if it's there it uses the function-relative line
number. I'm guessing that's also related to the difference i mentioned seeing in
my last e-mail.

(I think i'll probably stop using ksh-style definitions....)

dana



  reply	other threads:[~2017-12-15 18:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20171210232854epcas2p2f9d4f0ac2ad31feb5a54d61da49e7140@epcas2p2.samsung.com>
2017-12-10 23:28 ` dana
2017-12-11  9:41   ` Peter Stephenson
2017-12-11 10:12     ` Peter Stephenson
2017-12-11 21:57       ` dana
2017-12-15 10:21         ` Peter Stephenson
2017-12-15 18:45           ` dana [this message]
2017-12-16 21:10             ` Bart Schaefer
2017-12-16 22:33               ` dana
2017-12-18  9:01             ` Peter Stephenson
2017-12-20 17:39               ` Peter Stephenson
2017-12-20 22:26                 ` dana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FDA58405-4654-4DFC-951F-7E467CF836B2@dana.is \
    --to=dana@dana.is \
    --cc=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).