From: Joey Pabalinas <joeypabalinas@gmail.com>
To: schaefer@brasslantern.com
Cc: dana@dana.is, zsh-workers@zsh.org,
Joey Pabalinas <joeypabalinas@gmail.com>
Subject: [PATCH 3/3] jp: Add `dupstring()` fallback to `zhtricat()`
Date: Sun, 14 Jan 2018 05:23:44 -1000 [thread overview]
Message-ID: <20180114152344.12018-4-joeypabalinas@gmail.com> (raw)
In-Reply-To: <20180114152344.12018-1-joeypabalinas@gmail.com>
Add `dupstring()` fallback machanism to guard against NULL derefs
in 3-argument concat function.
Signed-off-by: Joey Pabalinas <joeypabalinas@gmail.com>
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/Src/string.c b/Src/string.c
index 038624d65a9f533494..df7e932061dbfbaab2 100644
--- a/Src/string.c
+++ b/Src/string.c
@@ -126,9 +126,16 @@ mod_export char *
zhtricat(char const *s1, char const *s2, char const *s3)
{
char *ptr;
- size_t l1 = strlen(s1);
- size_t l2 = strlen(s2);
+ size_t l1, l2;
+ /* String duplicate fallback to prevent NULL derefs */
+ if (!s1 && !s2)
+ return dupstring(s3);
+ if (!s1)
+ l1 = 0, s1 = s2;
+ else
+ l1 = strlen(s1);
+ l2 = strlen(s2);
ptr = (char *)zhalloc(l1 + l2 + strlen(s3) + 1);
strcpy(ptr, s1);
strcpy(ptr + l1, s2);
--
2.15.1
next prev parent reply other threads:[~2018-01-14 15:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-14 15:23 [PATCH 0/3] jp: Patchset for parameter expansion segfaults Joey Pabalinas
2018-01-14 15:23 ` [PATCH 1/3] jp: Fix segfaults during parameter expansion Joey Pabalinas
2018-01-14 15:23 ` [PATCH 2/3] jp: Use `(nil)` for empty identifier strings Joey Pabalinas
2018-01-14 15:43 ` Daniel Shahaf
2018-01-14 16:55 ` Joey Pabalinas
2018-01-14 20:30 ` Bart Schaefer
2018-01-14 15:23 ` Joey Pabalinas [this message]
2018-01-14 15:29 ` [PATCH 3/3] jp: Add `dupstring()` fallback to `zhtricat()` Joey Pabalinas
2018-01-21 17:56 ` Bart Schaefer
2018-01-14 20:41 ` [PATCH 0/3] jp: Patchset for parameter expansion segfaults Bart Schaefer
2018-01-18 22:58 ` Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180114152344.12018-4-joeypabalinas@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=dana@dana.is \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).