zsh-workers
 help / color / mirror / code / Atom feed
From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>, dana <dana@dana.is>
Subject: Re: [PATCH 0/3] jp: Patchset for parameter expansion segfaults
Date: Thu, 18 Jan 2018 12:58:29 -1000	[thread overview]
Message-ID: <20180118225829.wuvtm2l6vuplwchr@gmail.com> (raw)
In-Reply-To: <CAH+w=7YiRKwfNE9aZ-3jvQkQjwNmmnqQRyo5TGDOz80jmyioNQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]

On Sun, Jan 14, 2018 at 12:41:05PM -0800, Bart Schaefer wrote:
> With appreciation for your efforts here, preventing segfaults is not
> the correct goal.  The goal should be that the software produces the
> correct results.
> 
> Trapping bad pointers in the string copy/catenate routines potentially
> masks more serious errors; it introduces what only appears to be
> error-free operation in cases that probably ought to fail.  A segfault
> in zhtricat() is nearly always an indication that the calling code is
> doing something wrong, and covering that up only makes it harder to
> find what that is.
> 
> At the very least any such "succeed in spite of caller screwup" code
> should be wrapped in #ifndef DEBUG or the like.

No worries, I understand and wholeheartedly agree with that
philosophy. It would definitely be better to go over the
calling code and figure out exactly where the wrong assumptions
are being made with respect to intended behavior.

When I have a bit more free time I'll hopefully do just that, cheers.

-- 
Joey Pabalinas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2018-01-18 22:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14 15:23 Joey Pabalinas
2018-01-14 15:23 ` [PATCH 1/3] jp: Fix segfaults during parameter expansion Joey Pabalinas
2018-01-14 15:23 ` [PATCH 2/3] jp: Use `(nil)` for empty identifier strings Joey Pabalinas
2018-01-14 15:43   ` Daniel Shahaf
2018-01-14 16:55     ` Joey Pabalinas
2018-01-14 20:30   ` Bart Schaefer
2018-01-14 15:23 ` [PATCH 3/3] jp: Add `dupstring()` fallback to `zhtricat()` Joey Pabalinas
2018-01-14 15:29   ` Joey Pabalinas
2018-01-21 17:56     ` Bart Schaefer
2018-01-14 20:41 ` [PATCH 0/3] jp: Patchset for parameter expansion segfaults Bart Schaefer
2018-01-18 22:58   ` Joey Pabalinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180118225829.wuvtm2l6vuplwchr@gmail.com \
    --to=joeypabalinas@gmail.com \
    --cc=dana@dana.is \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).