zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Cc: dana <dana@dana.is>, Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH 0/3] jp: Patchset for parameter expansion segfaults
Date: Sun, 14 Jan 2018 12:41:05 -0800	[thread overview]
Message-ID: <CAH+w=7YiRKwfNE9aZ-3jvQkQjwNmmnqQRyo5TGDOz80jmyioNQ@mail.gmail.com> (raw)
In-Reply-To: <20180114152344.12018-1-joeypabalinas@gmail.com>

On Sun, Jan 14, 2018 at 7:23 AM, Joey Pabalinas <joeypabalinas@gmail.com> wrote:
>
> Joey Pabalinas (3):
>   - Fix segfaults during parameter expansion
>   - Use `(nil)` for empty identifier strings
>   - Add `dupstring()` fallback to `zhtricat()`

With appreciation for your efforts here, preventing segfaults is not
the correct goal.  The goal should be that the software produces the
correct results.

Trapping bad pointers in the string copy/catenate routines potentially
masks more serious errors; it introduces what only appears to be
error-free operation in cases that probably ought to fail.  A segfault
in zhtricat() is nearly always an indication that the calling code is
doing something wrong, and covering that up only makes it harder to
find what that is.

At the very least any such "succeed in spite of caller screwup" code
should be wrapped in #ifndef DEBUG or the like.


  parent reply	other threads:[~2018-01-14 20:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-14 15:23 Joey Pabalinas
2018-01-14 15:23 ` [PATCH 1/3] jp: Fix segfaults during parameter expansion Joey Pabalinas
2018-01-14 15:23 ` [PATCH 2/3] jp: Use `(nil)` for empty identifier strings Joey Pabalinas
2018-01-14 15:43   ` Daniel Shahaf
2018-01-14 16:55     ` Joey Pabalinas
2018-01-14 20:30   ` Bart Schaefer
2018-01-14 15:23 ` [PATCH 3/3] jp: Add `dupstring()` fallback to `zhtricat()` Joey Pabalinas
2018-01-14 15:29   ` Joey Pabalinas
2018-01-21 17:56     ` Bart Schaefer
2018-01-14 20:41 ` Bart Schaefer [this message]
2018-01-18 22:58   ` [PATCH 0/3] jp: Patchset for parameter expansion segfaults Joey Pabalinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7YiRKwfNE9aZ-3jvQkQjwNmmnqQRyo5TGDOz80jmyioNQ@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=dana@dana.is \
    --cc=joeypabalinas@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).