zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: <zsh-workers@zsh.org>
Subject: Re: [PATCH] [long] typeset doesn't report tied parameters (and related issues)
Date: Mon, 8 Oct 2018 10:05:55 +0100	[thread overview]
Message-ID: <20181008090557eucas1p11f18ef9ca4a6e3cc09fd59242f344f96~bltk3bsqO1947719477eucas1p1q@eucas1p1.samsung.com> (raw)
In-Reply-To: <20181007133545.zzkrbc3ed6shnk3e@chaz.gmail.com>

On Sun, 2018-10-07 at 14:35 +0100, Stephane Chazelas wrote:
> 2018-09-24 22:05:50 +0100, Stephane Chazelas:
> It would be useful for "typeset -p", or "typeset +m" or
> ${(t)param} or $parameters[param] to report the fact that the
> array is tied (and how for typeset -p) including for special
> ones that are created as such (like PATH to path).
>
> This patch attempts to address that.  While writing it, I found
> a number of related "issues" or possible areas of improvement,
> most of them minor.  That ends up being quite a large change.  I
> didn't initially intend to spend that much effort on it, I'm not
> very familiar with the source code (though a lot more now than
> when I started). So even though I've done quite a bit of
> testing, I think it should be reviewed by someone with more
> intimate knowledge of the code.

Thanks, I did't see anything obviously weird and it's well tested.  I'm
inclined to commit it and see what happens.  Any problems are most
likely to be combinations / juxtapositions that nobody's thought about.

pws


  reply	other threads:[~2018-10-08  9:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-24 21:05 [PATCH] typeset -p doesn't report -U (unique) attribute Stephane Chazelas
2018-09-25 16:41 ` Daniel Shahaf
2018-10-07 13:35 ` [PATCH] [long] typeset doesn't report tied parameters (and related issues) Stephane Chazelas
2018-10-08  9:05   ` Peter Stephenson [this message]
     [not found]     ` <CACeGjnUhNqca7jLAR0KKSxobzDd+xXdAe4BeUeRpxu2CTp_zkA@mail.gmail.com>
2018-10-08 14:10       ` Peter Stephenson
2018-10-08 14:28         ` Daniel Shahaf
2018-10-08 15:24           ` Peter Stephenson
2018-10-08 15:49             ` Daniel Shahaf
2018-10-08 15:57               ` Bart Schaefer
2018-10-08 16:06                 ` Daniel Shahaf
2018-10-08 16:52                   ` Bart Schaefer
2018-10-08 16:58                     ` Peter Stephenson
2018-10-08 16:02               ` Daniel Shahaf
2018-10-08 16:19                 ` Peter Stephenson
2018-10-08 16:43               ` Peter Stephenson
2018-10-08 16:58                 ` Daniel Shahaf
2018-10-08 17:14                   ` Bart Schaefer
2018-10-08 19:39                     ` Stephane Chazelas
2018-10-09  9:02                   ` Peter Stephenson
     [not found]                   ` <1539075745.1499.2.camel@samsung.com>
2018-10-09  9:44                     ` Peter Stephenson
2018-10-09 16:52                       ` Bart Schaefer
2018-10-09 23:40                         ` Vin Shelton
2018-10-08 15:54             ` Bart Schaefer
2018-10-08 16:40               ` Bart Schaefer
2018-10-09 10:59   ` local read-only variables (Was:[PATCH] [long] typeset doesn't report tied parameters (and related issues)) Stephane Chazelas
2018-10-11  9:45   ` [PATCH] [long] typeset doesn't report tied parameters (and related issues) Oliver Kiddle
2018-10-11 12:46     ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20181008090557eucas1p11f18ef9ca4a6e3cc09fd59242f344f96~bltk3bsqO1947719477eucas1p1q@eucas1p1.samsung.com' \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).