zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: <zsh-workers@zsh.org>
Subject: Re: [PATCH] [long] typeset doesn't report tied parameters (and related issues)
Date: Mon, 8 Oct 2018 17:19:46 +0100	[thread overview]
Message-ID: <20181008161947eucas1p283c719b6b016771e32ae61bff41fe5f4~broXdO7hi1921019210eucas1p2Y@eucas1p2.samsung.com> (raw)
In-Reply-To: <1539014554.1395393.1534752912.4E28F19D@webmail.messagingengine.com>

On Mon, 2018-10-08 at 16:02 +0000, Daniel Shahaf wrote:
> Daniel Shahaf wrote on Mon, 08 Oct 2018 15:49 +0000:
> > 
> > I did.  If someone wants to look into it (not necessarly Peter), be my
> > guest.
> It's crashing on the 'print $manpath' line in B02.

Next step is to see if that code chunk on its own is responsible,

 typeset MANPATH
 manpath=(/ /)
 typeset -UT MANPATH manpath
 print $manpath

--- that's going to need to be within a function to have the right
effect, so

() {
  typeset MANPATH
  manpath=(/ /)
  typeset -UT MANPATH manpath
  print $manpath
}

--- or if there's some precursor, and if the latter whether $manpath is
accessible without a crash at the end of the previous test.  If yes to
both it's going to be interesting, but that seems unlikely.  If there's
a precursor hopefully it's some previous assignment to manpath or
MANPATH that can be tracked down and added to the above by hand.
Printing out "$manpath $MANPATH ${(t)manpath} ${(t)MANPATH}" at the top
of the test (before it starts crashing) might or might not help.

Presumably, then, the bin_typeset call is leaving manpath in a bad
state.  This is certainly a somewhat hybrid case as manpath is a special
while -T is for user tying --- so this could be down to consistently
making sure the specialness stays.  It's not clear from what I've seen
so far if the valgrind error is actually within the above code.

pws


  reply	other threads:[~2018-10-08 16:20 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-24 21:05 [PATCH] typeset -p doesn't report -U (unique) attribute Stephane Chazelas
2018-09-25 16:41 ` Daniel Shahaf
2018-10-07 13:35 ` [PATCH] [long] typeset doesn't report tied parameters (and related issues) Stephane Chazelas
2018-10-08  9:05   ` Peter Stephenson
     [not found]     ` <CACeGjnUhNqca7jLAR0KKSxobzDd+xXdAe4BeUeRpxu2CTp_zkA@mail.gmail.com>
2018-10-08 14:10       ` Peter Stephenson
2018-10-08 14:28         ` Daniel Shahaf
2018-10-08 15:24           ` Peter Stephenson
2018-10-08 15:49             ` Daniel Shahaf
2018-10-08 15:57               ` Bart Schaefer
2018-10-08 16:06                 ` Daniel Shahaf
2018-10-08 16:52                   ` Bart Schaefer
2018-10-08 16:58                     ` Peter Stephenson
2018-10-08 16:02               ` Daniel Shahaf
2018-10-08 16:19                 ` Peter Stephenson [this message]
2018-10-08 16:43               ` Peter Stephenson
2018-10-08 16:58                 ` Daniel Shahaf
2018-10-08 17:14                   ` Bart Schaefer
2018-10-08 19:39                     ` Stephane Chazelas
2018-10-09  9:02                   ` Peter Stephenson
     [not found]                   ` <1539075745.1499.2.camel@samsung.com>
2018-10-09  9:44                     ` Peter Stephenson
2018-10-09 16:52                       ` Bart Schaefer
2018-10-09 23:40                         ` Vin Shelton
2018-10-08 15:54             ` Bart Schaefer
2018-10-08 16:40               ` Bart Schaefer
2018-10-09 10:59   ` local read-only variables (Was:[PATCH] [long] typeset doesn't report tied parameters (and related issues)) Stephane Chazelas
2018-10-11  9:45   ` [PATCH] [long] typeset doesn't report tied parameters (and related issues) Oliver Kiddle
2018-10-11 12:46     ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20181008161947eucas1p283c719b6b016771e32ae61bff41fe5f4~broXdO7hi1921019210eucas1p2Y@eucas1p2.samsung.com' \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).