From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] [long] typeset doesn't report tied parameters (and related issues)
Date: Thu, 11 Oct 2018 11:45:22 +0200 [thread overview]
Message-ID: <90011-1539251122.433925@_kdU.FXyh.KLiu> (raw)
In-Reply-To: <20181007133545.zzkrbc3ed6shnk3e@chaz.gmail.com>
On 7 Oct, Stephane Chazelas wrote:
> +#define PM_NAMEDDIR (1<<31) /* has a corresponding nameddirtab entry */
On a 32-bit system, this now results in integer overflow compiler
warnings. flags in struct hashnode is declared as being of type int.
unsigned int might have been a better choice for a variable holding bit
flags in the first place but struct hashnode is widely used so changing
the type probably is not a matter of just changing the one line. With
that in mind, should we change it straight to uint64_t and open up space
for expansion?
We don't have any existing uses of stdint.h types like uint64_t. I
wouldn't blink at using them in other codebases but do we need to add
any autoconf magic to preserve wide portability?
Oliver
next prev parent reply other threads:[~2018-10-11 9:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 21:05 [PATCH] typeset -p doesn't report -U (unique) attribute Stephane Chazelas
2018-09-25 16:41 ` Daniel Shahaf
2018-10-07 13:35 ` [PATCH] [long] typeset doesn't report tied parameters (and related issues) Stephane Chazelas
2018-10-08 9:05 ` Peter Stephenson
[not found] ` <CACeGjnUhNqca7jLAR0KKSxobzDd+xXdAe4BeUeRpxu2CTp_zkA@mail.gmail.com>
2018-10-08 14:10 ` Peter Stephenson
2018-10-08 14:28 ` Daniel Shahaf
2018-10-08 15:24 ` Peter Stephenson
2018-10-08 15:49 ` Daniel Shahaf
2018-10-08 15:57 ` Bart Schaefer
2018-10-08 16:06 ` Daniel Shahaf
2018-10-08 16:52 ` Bart Schaefer
2018-10-08 16:58 ` Peter Stephenson
2018-10-08 16:02 ` Daniel Shahaf
2018-10-08 16:19 ` Peter Stephenson
2018-10-08 16:43 ` Peter Stephenson
2018-10-08 16:58 ` Daniel Shahaf
2018-10-08 17:14 ` Bart Schaefer
2018-10-08 19:39 ` Stephane Chazelas
2018-10-09 9:02 ` Peter Stephenson
[not found] ` <1539075745.1499.2.camel@samsung.com>
2018-10-09 9:44 ` Peter Stephenson
2018-10-09 16:52 ` Bart Schaefer
2018-10-09 23:40 ` Vin Shelton
2018-10-08 15:54 ` Bart Schaefer
2018-10-08 16:40 ` Bart Schaefer
2018-10-09 10:59 ` local read-only variables (Was:[PATCH] [long] typeset doesn't report tied parameters (and related issues)) Stephane Chazelas
2018-10-11 9:45 ` Oliver Kiddle [this message]
2018-10-11 12:46 ` [PATCH] [long] typeset doesn't report tied parameters (and related issues) Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90011-1539251122.433925@_kdU.FXyh.KLiu \
--to=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).