From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Frederick Zhang <frederick888@tsundere.moe>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] add missing read-only zfs property "space"
Date: Wed, 17 Jun 2020 08:38:12 +0000 [thread overview]
Message-ID: <20200617083812.16ac8afc@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20200605081136.82262-1-frederick888@tsundere.moe>
Thanks for the patch.
I see that «zfs list -o space» works, but I don't see any reference to
the value «space» in the help output (`zfs list -o foobar 2>&1`) or man
page. Is that value supported and undocumented? Or is it undocumented
because it's deprecated?
workers@, could someone take over the review, please? I have a few
patches to finish and don't want to spread myself too thin.
Cheers,
Daniel
Frederick Zhang wrote on Fri, 05 Jun 2020 18:11 +1000:
> Signed-off-by: Frederick Zhang <frederick888@tsundere.moe>
> ---
> Completion/Unix/Command/_zfs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Although it's only documented under 'zfs list', it seems to be available
> to other subcommands as well, e.g. 'zfs get'.
>
> diff --git a/Completion/Unix/Command/_zfs b/Completion/Unix/Command/_zfs
> index 814358bc7..452e1160d 100644
> --- a/Completion/Unix/Command/_zfs
> +++ b/Completion/Unix/Command/_zfs
> @@ -132,9 +132,9 @@ _zfs() {
> )
>
> # TODO: userused@ and groupused@ could have more extensive handling
> ro_properties=(
> - "name" "type" "creation" "used" "available" "referenced"
> + "name" "type" "creation" "space" "used" "available" "referenced"
> "compressratio" "mounted" "origin" "usedbychildren"
> "usedbydataset" "usedbyrefreservation" "usedbysnapshots"
> "defer_destroy" "userused@" "userrefs" "groupused@"
> "keychangedate" "keystatus" "rekeydate"
next prev parent reply other threads:[~2020-06-17 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 8:11 Frederick Zhang
2020-06-17 8:38 ` Daniel Shahaf [this message]
2020-06-17 8:42 ` Frederick Zhang
2020-06-17 14:01 ` Eric Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200617083812.16ac8afc@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=frederick888@tsundere.moe \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).