* [PATCH] _rpmbuild: complete non-options after `rpmbuild -[btr]?'
@ 2021-02-27 11:55 Arseny Maslennikov
2021-02-27 13:24 ` Daniel Shahaf
0 siblings, 1 reply; 3+ messages in thread
From: Arseny Maslennikov @ 2021-02-27 11:55 UTC (permalink / raw)
To: zsh-workers; +Cc: Arseny Maslennikov
The "tmp" array is being filled up with specstrings for _arguments in
all three cases, but is unused afterwards. Thus non-option arguments
after e. g. `rpmbuild -ba' are not being offered as completion matches.
---
Completion/Redhat/Command/_rpm | 1 +
1 file changed, 1 insertion(+)
diff --git a/Completion/Redhat/Command/_rpm b/Completion/Redhat/Command/_rpm
index e3469245f..6e4a1e6a1 100644
--- a/Completion/Redhat/Command/_rpm
+++ b/Completion/Redhat/Command/_rpm
@@ -283,6 +283,7 @@ _rpm () {
build_t) tmp=( '*:tar file:_files -g "*.(#i)tar(.*|)(-.)"' ) ;|
build_?)
_arguments -s -C $buildopts $commonopts $pathopts \
+ "${tmp[@]}"
;;
checksig)
_arguments -s -C \!-K \
--
2.29.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] _rpmbuild: complete non-options after `rpmbuild -[btr]?'
2021-02-27 11:55 [PATCH] _rpmbuild: complete non-options after `rpmbuild -[btr]?' Arseny Maslennikov
@ 2021-02-27 13:24 ` Daniel Shahaf
2021-02-27 14:36 ` Arseny Maslennikov
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Shahaf @ 2021-02-27 13:24 UTC (permalink / raw)
To: Arseny Maslennikov; +Cc: zsh-workers
Already fixed in 47323. Please write patches against latest master.
Thanks!
Arseny Maslennikov wrote on Sat, Feb 27, 2021 at 14:55:01 +0300:
> The "tmp" array is being filled up with specstrings for _arguments in
> all three cases, but is unused afterwards. Thus non-option arguments
> after e. g. `rpmbuild -ba' are not being offered as completion matches.
> ---
> Completion/Redhat/Command/_rpm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Completion/Redhat/Command/_rpm b/Completion/Redhat/Command/_rpm
> index e3469245f..6e4a1e6a1 100644
> --- a/Completion/Redhat/Command/_rpm
> +++ b/Completion/Redhat/Command/_rpm
> @@ -283,6 +283,7 @@ _rpm () {
> build_t) tmp=( '*:tar file:_files -g "*.(#i)tar(.*|)(-.)"' ) ;|
> build_?)
> _arguments -s -C $buildopts $commonopts $pathopts \
> + "${tmp[@]}"
> ;;
> checksig)
> _arguments -s -C \!-K \
> --
> 2.29.2
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] _rpmbuild: complete non-options after `rpmbuild -[btr]?'
2021-02-27 13:24 ` Daniel Shahaf
@ 2021-02-27 14:36 ` Arseny Maslennikov
0 siblings, 0 replies; 3+ messages in thread
From: Arseny Maslennikov @ 2021-02-27 14:36 UTC (permalink / raw)
To: Daniel Shahaf; +Cc: zsh-workers
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
On Sat, Feb 27, 2021 at 01:24:06PM +0000, Daniel Shahaf wrote:
> Already fixed in 47323. Please write patches against latest master.
> Thanks!
Sorry for the noise. I have encountered the problem and tested the fix
on a downstream branch based on zsh 5.8; it hadn't occurred to me that
the release was a while ago.
>
> Arseny Maslennikov wrote on Sat, Feb 27, 2021 at 14:55:01 +0300:
> > The "tmp" array is being filled up with specstrings for _arguments in
> > all three cases, but is unused afterwards. Thus non-option arguments
> > after e. g. `rpmbuild -ba' are not being offered as completion matches.
> > ---
> > Completion/Redhat/Command/_rpm | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Completion/Redhat/Command/_rpm b/Completion/Redhat/Command/_rpm
> > index e3469245f..6e4a1e6a1 100644
> > --- a/Completion/Redhat/Command/_rpm
> > +++ b/Completion/Redhat/Command/_rpm
> > @@ -283,6 +283,7 @@ _rpm () {
> > build_t) tmp=( '*:tar file:_files -g "*.(#i)tar(.*|)(-.)"' ) ;|
> > build_?)
> > _arguments -s -C $buildopts $commonopts $pathopts \
> > + "${tmp[@]}"
> > ;;
> > checksig)
> > _arguments -s -C \!-K \
> > --
> > 2.29.2
> >
> >
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-27 14:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-27 11:55 [PATCH] _rpmbuild: complete non-options after `rpmbuild -[btr]?' Arseny Maslennikov
2021-02-27 13:24 ` Daniel Shahaf
2021-02-27 14:36 ` Arseny Maslennikov
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).