zsh-workers
 help / color / mirror / code / Atom feed
From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Zsh hackers list <zsh-workers@zsh.org>
Cc: Sebastian Gniazdowski <sgniazdowski@gmail.com>
Subject: Re: [BUG?] If true-color is used, overlapping colors do not work
Date: Fri, 09 Nov 2018 02:28:21 +0100	[thread overview]
Message-ID: <20626-1541726901.821000@xGvJ.shtD.SkCN> (raw)
In-Reply-To: <CAKc7PVAPxxtSaV5qMWzaueW+9_ZHXrHYX2032cHYYDq3Gh399w@mail.gmail.com>

Sebastian Gniazdowski wrote:
> I've applied the patch and recompiled, and the tests or the Ctrl-a
> (with Src/zsh -fi) snippet show now change?

Working through each of your tests manually, they all seem to work fine
for me if judged purely on the basis of what I see in a terminal. I've
checked more than one terminal programme including ones with and without
true colour support.

> I hope the tests will be working system-wide, otherwise it's a show
> stopper for them. Could you maybe provide the test wrong answer? If
> you are sure that it's about TERM= value, then ok, I've observed this
> too, and export TERM=xterm-256color fixed the tests (on Linux).
> Searching for proper termcap seems a good idea. I might also find a
> docker image with the same OS and test it.

I get differences before the tests even reach the final buffer state. The
fact that all the setup lines get repeated back in the test output
really isn't helping the matter. The differences are all escape
sequences which diff is not showing, e.g 1b 5b 6d occurring at the start
of each line. There are also further differences that can be put down to a
difference of termcap definition. The only hope would be to strip the output
down to just the section actually being tested (which comptest manages),
also using something like:
  zle_highlight=( fg_start_code:FGSTART fg_end_code:FGEND fg_default_code:FGDEF )
and perhaps zle -T somehow to map escape sequences to something readable
somehow contriving to set TERM to something that claims 256 colour support.
And, only relying on the portable subset of sed syntax.
It's not without reason that I was too lazy to attempt this in the first
place.

Oliver

  reply	other threads:[~2018-11-09  1:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07 13:19 Sebastian Gniazdowski
2018-11-07 14:40 ` Sebastian Gniazdowski
2018-11-07 19:19   ` Sebastian Gniazdowski
2018-11-08  3:48     ` Oliver Kiddle
2018-11-08  9:25       ` Sebastian Gniazdowski
2018-11-08  3:03 ` Oliver Kiddle
2018-11-08  9:19   ` Sebastian Gniazdowski
2018-11-09  1:28     ` Oliver Kiddle [this message]
2018-11-09 15:39       ` Sebastian Gniazdowski
2018-11-11  0:43       ` Sebastian Gniazdowski
2018-11-11  5:11         ` Sebastian Gniazdowski
2018-11-24 17:32         ` highlight test cases (was Re: [BUG?] If true-color is used, overlapping colors do not work) Oliver Kiddle
2018-11-30  0:34           ` Sebastian Gniazdowski
2018-12-07  1:55             ` [BUG] General 256 colors bug – zle_highlight / fg_start_code, etc. is not respected (was: highlight test cases) Sebastian Gniazdowski
2018-12-07 20:26               ` Sebastian Gniazdowski
2018-12-09 19:13                 ` Daniel Shahaf
2018-12-11  8:06                   ` Sebastian Gniazdowski
2018-12-10  2:54             ` highlight test cases (was Re: [BUG?] If true-color is used, overlapping colors do not work) Oliver Kiddle
2018-12-10 23:51               ` Sebastian Gniazdowski
2018-12-10 23:54                 ` Sebastian Gniazdowski
2018-11-11  5:38       ` X04 zle highlight tests, near-color bug Sebastian Gniazdowski
2018-11-18 15:34         ` Sebastian Gniazdowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20626-1541726901.821000@xGvJ.shtD.SkCN \
    --to=okiddle@yahoo.co.uk \
    --cc=sgniazdowski@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).